fix(stop): fix stop when stop words not in end#1724
Closed
geeker-smallwhite wants to merge 0 commit intovllm-project:mainfrom
Closed
fix(stop): fix stop when stop words not in end#1724geeker-smallwhite wants to merge 0 commit intovllm-project:mainfrom
geeker-smallwhite wants to merge 0 commit intovllm-project:mainfrom
Conversation
|
I'd like to see this fixed as well. One note on your PR though, it may be necessary to write a test for the logprobs, to make sure that the correct logprobs are returned. |
jinyouzhi
pushed a commit
to jinyouzhi/vllm
that referenced
this pull request
Sep 11, 2025
## Essential Elements of an Effective PR Description Checklist - [ ] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)". - [ ] The test plan, such as providing test command. - [ ] The test results, such as pasting the results comparison before and after, or e2e results ## Purpose ## Test Plan ## Test Result <!--- pyml disable-next-line no-emphasis-as-heading --> --------- Signed-off-by: tianyuan211 <paulyuen@umich.edu> Co-authored-by: Wei Lin <forever871001@163.com> Co-authored-by: Bob Zhu <bob.zhu@intel.com>
jinyouzhi
pushed a commit
to jinyouzhi/vllm
that referenced
this pull request
Sep 12, 2025
## Essential Elements of an Effective PR Description Checklist - [ ] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)". - [ ] The test plan, such as providing test command. - [ ] The test results, such as pasting the results comparison before and after, or e2e results ## Purpose ## Test Plan ## Test Result <!--- pyml disable-next-line no-emphasis-as-heading --> --------- Signed-off-by: tianyuan211 <paulyuen@umich.edu> Co-authored-by: Wei Lin <forever871001@163.com> Co-authored-by: Bob Zhu <bob.zhu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop words may not stop where generating text.