Skip to content

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Apr 26, 2025

With #17159, whenever vLLM is installed with VLLM_USE_PRECOMPILED,
it will inadvertently copy the __init__.py from vllm_flash_attn, which will generate bad diff

This PR removes the __init__.py copy in setup.py, and add a function stubs for all functions within the flash_attn_interface.py

Signed-off-by: Aaron Pham [email protected]

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm aarnphm requested a review from DarkLight1337 April 26, 2025 12:24
@aarnphm aarnphm changed the title [Chore] added stubs for development [Chore] added stubs for vllm_flash_attn during development mode Apr 26, 2025
@mergify mergify bot added the ci/build label Apr 26, 2025
@aarnphm aarnphm requested a review from DarkLight1337 April 26, 2025 13:11
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 26, 2025 13:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 26, 2025
@vllm-bot vllm-bot merged commit e782e0a into vllm-project:main Apr 26, 2025
60 of 77 checks passed
@aarnphm aarnphm deleted the fix/correct-import-stub branch April 26, 2025 15:00
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants