Skip to content

[WIP][Attention] Update FlashMLA#17027

Closed
LucasWilkinson wants to merge 2 commits intovllm-project:mainfrom
neuralmagic:lwilkinson/flashmla-update
Closed

[WIP][Attention] Update FlashMLA#17027
LucasWilkinson wants to merge 2 commits intovllm-project:mainfrom
neuralmagic:lwilkinson/flashmla-update

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Apr 23, 2025

Update to the latest FlashMLA

Accuracy

VLLM_USE_V1=0 lm_eval --model vllm --model_args pretrained=deepseek-ai/DeepSeek-V2-Lite-Chat,tensor_parallel_size=2,dtype=auto,gpu_memory_utilization=0.9,trust_remote_code=True,max_model_len=16384 --task gsm8k --num_fewshot 5  --batch_size auto

|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.6634|±  |0.0130|
|     |       |strict-match    |     5|exact_match|↑  |0.6596|±  |0.0131|

VLLM_USE_V1=1 lm_eval --model vllm --model_args pretrained=deepseek-ai/DeepSeek-V2-Lite-Chat,tensor_parallel_size=2,dtype=auto,gpu_memory_utilization=0.9,trust_remote_code=True,max_model_len=16384 --task gsm8k --num_fewshot 5  --batch_size auto

|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.6710|±  |0.0129|
|     |       |strict-match    |     5|exact_match|↑  |0.6626|±  |0.0130|

Benchmarking 8xH200 DeepSeek-R1

main

  input_tokens output_tokens  vllm_output_toks/s
0         1000          2000         1147.119850
1         5000          1000          883.519124
2        10000           500          472.130590
3        30000           100           43.572829
4     sharegpt      sharegpt         1387.960241

this PR

  input_tokens output_tokens  vllm_output_toks/s
0         1000          2000         1118.442740
1         5000          1000          867.962366
2        10000           500          466.229469
3        30000           100           43.298352
4     sharegpt      sharegpt         1376.845286

Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 23, 2025
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@mergify
Copy link

mergify bot commented Sep 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 8, 2025
@hmellor
Copy link
Member

hmellor commented Oct 3, 2025

Closing as stale

@hmellor hmellor closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants