Skip to content

[Perf] Optimize _update_states for GPU model runner #16910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

[Perf] Optimize _update_states for GPU model runner #16910

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c375625
optimize _update_states
SnowCharmQ Apr 21, 2025
a82913a
revert change to be better clear
SnowCharmQ Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions vllm/v1/worker/gpu_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,15 +454,11 @@ def _update_states(self, scheduler_output: "SchedulerOutput") -> None:

# Add the new or resumed requests to the persistent batch.
# The smaller empty indices are filled first.
removed_req_indices = sorted(removed_req_indices, reverse=True)
removed_req_indices.sort(reverse=True)
for req_id in req_ids_to_add:
req_state = self.requests[req_id]
if removed_req_indices:
# Fill the empty index.
req_index = removed_req_indices.pop()
else:
# Append to the end.
req_index = None
req_index = removed_req_indices.pop(
) if removed_req_indices else None
self.input_batch.add_request(req_state, req_index)

# Condense the batched states if there are empty indices.
Expand Down