-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[ROCM] Bind triton version to 3.2 in requirements-built.txt #16664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCM] Bind triton version to 3.2 in requirements-built.txt #16664
Conversation
Signed-off-by: Sage Moore <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which package is pulling in triton 3.3?
|
Looks like xgrammar I suspect it is just pulling in the triton package without specifying the version. I tried this on an nvidia system and I think we dodge the issue because torch explicitly depends on the triton package instead of bundling it |
…ject#16664) Signed-off-by: Sage Moore <[email protected]>
…ject#16664) Signed-off-by: Sage Moore <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…ject#16664) Signed-off-by: Sage Moore <[email protected]>
…ject#16664) Signed-off-by: Sage Moore <[email protected]>
…ject#16664) Signed-off-by: Sage Moore <[email protected]> Signed-off-by: Mu Huai <[email protected]>
See above. This should fix the baremetal rocm build. Another package is pulling in triton version 3.3 which doesn't match with the version that torch comes with (3.2). This is causing various exceptions to be thrown.