Skip to content

[CI/Build] Fix LoRA OOM #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025
Merged

[CI/Build] Fix LoRA OOM #16624

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0987dfa
Done
jeejeelee Apr 15, 2025
ba0d781
Fix
jeejeelee Apr 15, 2025
fd7bc82
Add lmimit
jeejeelee Apr 15, 2025
0c3b443
Add image limit
jeejeelee Apr 15, 2025
6f84377
Fix
jeejeelee Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/lora/test_minicpmv_tp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def test_minicpmv_lora(minicpmv_lora_files):
max_loras=2,
max_lora_rank=8,
enforce_eager=True,
max_model_len=2048,
trust_remote_code=True,
enable_chunked_prefill=True,
)
output1 = do_sample(llm, minicpmv_lora_files, lora_id=1)
for i in range(len(EXPECTED_OUTPUT)):
Expand All @@ -92,8 +92,6 @@ def test_minicpmv_tp4_wo_fully_sharded_loras(minicpmv_lora_files):
max_lora_rank=64,
tensor_parallel_size=4,
trust_remote_code=True,
enforce_eager=True,
enable_chunked_prefill=True,
)
output_tp = do_sample(llm, minicpmv_lora_files, lora_id=1)
for i in range(len(EXPECTED_OUTPUT)):
Expand All @@ -116,7 +114,6 @@ def test_minicpmv_tp4_fully_sharded_loras(minicpmv_lora_files):
tensor_parallel_size=4,
trust_remote_code=True,
fully_sharded_loras=True,
enable_chunked_prefill=True,
)
output_tp = do_sample(llm, minicpmv_lora_files, lora_id=1)
for i in range(len(EXPECTED_OUTPUT)):
Expand Down