Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 14, 2025

Issues were also seen when trying to install on Mac.

This PR inverts the condition to make it so that triton is only installed for x86 CPUs.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 14, 2025
@Isotr0py
Copy link
Member

IIRC, triton is never used by CPU backend. Not sure why it's introduced in cpu.txt TBH. 🤔

@hmellor
Copy link
Member Author

hmellor commented Apr 14, 2025

More context is here #16413

@Isotr0py
Copy link
Member

Hmmm, anyway, let's merge this PR to fix arm CPU installation.

@Isotr0py Isotr0py enabled auto-merge (squash) April 14, 2025 16:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 14, 2025
@Isotr0py Isotr0py merged commit 9883a18 into vllm-project:main Apr 14, 2025
40 of 42 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@hmellor hmellor deleted the fix-cpu-install branch April 24, 2025 16:22
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants