Skip to content

[Misc] remove warning if triton>=3.2.0 #16553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

[Misc] remove warning if triton>=3.2.0 #16553

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c853aa
[Misc] remove warning if triton>=3.2.0
DefTruth Apr 13, 2025
c595a31
[Misc] disable warning if triton>=3.2.0
DefTruth Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions vllm/attention/ops/triton_decode_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,12 @@

logger = logging.getLogger(__name__)

# TODO: Remove this when triton>=3.2.0. This issue will not affect performance
# Remove this warning when triton>=3.2.0. This issue will not affect performance
Copy link
Collaborator

@houseroad houseroad Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about: "only print the following warnings when triton version < 3.2.0. The issue won't affect performance or accuracy."

Copy link
Contributor Author

@DefTruth DefTruth Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# and accuracy.
logger.warning(
"The following error message 'operation scheduled before its operands' "
"can be ignored.")
if triton.__version__ < '3.2.0':
logger.warning(
"The following error message 'operation scheduled before its operands' "
"can be ignored.")


@triton.jit
Expand Down