-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Perf] Optimize Preparing Inputs for GPU Model Runner #16484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: snowcharm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SnowCharmQ, this is great!
On my clusters, it can achieve nearly a twofold performance improvement.
Presumably you're referring to the improvement of this loop, not end-to-end? :)
Hi @njhill, the improvement refers to the loop exactly. Sorry for the confusion :) |
Co-authored-by: Nick Hill <[email protected]>
|
Hi @njhill, I noticed an issue with the CI check. Do you have any idea what might be going wrong and how it can be resolved? |
|
I retried the test and it passes now |
…6484) Signed-off-by: snowcharm <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…6484) Signed-off-by: snowcharm <[email protected]> Co-authored-by: Nick Hill <[email protected]>
…6484) Signed-off-by: snowcharm <[email protected]> Co-authored-by: Nick Hill <[email protected]>
…6484) Signed-off-by: snowcharm <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Mu Huai <[email protected]>
This PR enhances the performance of the method
_prepare_inputsingpu_model_runner.pyby replacing the original Python loop implementation with map and numpy array operations.On my clusters, it can achieve nearly a twofold performance improvement.