Skip to content

Fix requires-python#16132

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
martinhoyer:patch-2
Apr 7, 2025
Merged

Fix requires-python#16132
vllm-bot merged 1 commit intovllm-project:mainfrom
martinhoyer:patch-2

Conversation

@martinhoyer
Copy link
Contributor

Previous <=3.12 would exclude micro versions, like 3.12.1.

Previous `<=3.12` would exclude micro versions, like 3.12.1.
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@reidliu41
Copy link
Contributor

thanks for you remind.

@reidliu41
Copy link
Contributor

@DarkLight1337 Sorry for inconvenience, I just test is = cannot include the micro version. could you pls merge this one? thanks

INFO: pip is looking at multiple versions of vllm to determine which version is compatible with other requirements. This could take a while.
ERROR: Package 'vllm' requires a different Python: 3.12.2 not in '<=3.12,>=3.9'

@yihong0618
Copy link
Contributor

yihong0618 commented Apr 7, 2025

I suggest do not add the < version like pervious since python3.13 could work most of it

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad for overlooking this, thanks for fixing!

@vllm-bot vllm-bot merged commit 2549c0d into vllm-project:main Apr 7, 2025
22 of 23 checks passed
@DarkLight1337
Copy link
Member

I suggest do not add the < version like pervious since python3.13 could work most of it

We don't officially support Python 3.13 yet, please see #13164

lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 7, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
Signed-off-by: Yang Wang <elainewy@meta.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants