Skip to content

s390x: Fix PyArrow build and add CPU test script for Buildkite CI #16036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

s390x: Fix PyArrow build and add CPU test script for Buildkite CI #16036

merged 1 commit into from
Apr 14, 2025

Conversation

@Nash-123
Copy link
Contributor

@Nash-123 Nash-123 commented Apr 3, 2025 •
edited by github-actions bot
Loading

Summary

This PR adds IBM Z (s390x) architecture support to vLLM by implementing Buildkite CI testing.

Changes

.buildkite/run-cpu-test-s390x.sh

  • Added new CI script for s390x-specific testing workflow

docker/Dockerfile.s390x

  • Fixed PyArrow compilation failures
  • Resolved huggingface-hub[hf-xet] incompatibility by building from source

Notes

Testing

Tested the job using a connected s390x Buildkite agent on IBM Cloud
Triggered pipeline from vLLM community Buildkite setup
Sample Build: CI Build #16786
PR Buildkite-CI:- vllm-project/ci-infra#84

c.c: @khluu

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 3, 2025
dilipgb
dilipgb reviewed Apr 4, 2025
View reviewed changes
@Nash-123 Nash-123 force-pushed the s390x/buildkite-ci-s390x-support branch from c61fe53 to 7aaaaae Compare April 4, 2025 14:49
@Nash-123 Nash-123 marked this pull request as ready for review April 7, 2025 06:32
khluu
khluu reviewed Apr 7, 2025
View reviewed changes
@Nash-123 Nash-123 force-pushed the s390x/buildkite-ci-s390x-support branch 2 times, most recently from 98e4afb to 772b4f8 Compare April 7, 2025 09:43
@Nash-123 Nash-123 force-pushed the s390x/buildkite-ci-s390x-support branch from 772b4f8 to 06012d3 Compare April 9, 2025 10:15
@khluu khluu enabled auto-merge (squash) April 10, 2025 06:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 10, 2025
@khluu khluu merged commit 7b5ecf7 into vllm-project:main Apr 14, 2025
41 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@Nash-123 @yangw-dev
s390x: Fix PyArrow build and add CPU test script for Buildkite CI (vl…
243553d 
…lm-project#16036)

Signed-off-by: Nishan Acharya <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
vaibhavjainwiz pushed a commit to vajain-rhods/vllm that referenced this pull request Apr 23, 2025
@Nash-123 @vaibhavjainwiz
s390x: Fix PyArrow build and add CPU test script for Buildkite CI (vl…
3e6b6a4 
…lm-project#16036)

Signed-off-by: Nishan Acharya <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 23, 2025
Closed
heyselbi pushed a commit to red-hat-data-services/vllm that referenced this pull request Apr 24, 2025
@Nash-123 @heyselbi
s390x: Fix PyArrow build and add CPU test script for Buildkite CI (vl…
c2a69eb 
…lm-project#16036)

Signed-off-by: Nishan Acharya <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@Nash-123 @dbyoung18
s390x: Fix PyArrow build and add CPU test script for Buildkite CI (vl…
fa7aba5 
…lm-project#16036)

Signed-off-by: Nishan Acharya <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@Nash-123 @lk-chen
s390x: Fix PyArrow build and add CPU test script for Buildkite CI (vl…
1781789 
…lm-project#16036)

Signed-off-by: Nishan Acharya <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Nash-123
s390x: Fix PyArrow build and add CPU test script for Buildkite CI (vl…
ea68852 
…lm-project#16036)

Signed-off-by: Nishan Acharya <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khluu khluu khluu approved these changes

+1 more reviewer

@dilipgb dilipgb dilipgb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nash-123 @khluu @dilipgb