Skip to content

[Draft] Translation API#15910

Closed
ywang96 wants to merge 1 commit intomainfrom
whisper-translate
Closed

[Draft] Translation API#15910
ywang96 wants to merge 1 commit intomainfrom
whisper-translate

Conversation

@ywang96
Copy link
Copy Markdown
Member

@ywang96 ywang96 commented Apr 1, 2025 •
edited by github-actions bot
Loading

No description provided.

@ywang96
initial
d3eddd6 
Signed-off-by: Roger Wang <ywang@roblox.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Apr 1, 2025
@DarkLight1337 DarkLight1337 added the multi-modality Related to multi-modality (#4194) label Apr 2, 2025
@DarkLight1337 DarkLight1337 moved this to In Progress in Multi-modality Core Apr 2, 2025
@ywang96 ywang96 self-assigned this Apr 3, 2025
@mgoin
Copy link
Copy Markdown
Member

mgoin commented Apr 3, 2025

cc @NickLucche

NickLucche
NickLucche approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for early peeking! 🙏🏻
I like the refactoring of the OpenAIServingTranscription class, great work!

vllm/entrypoints/openai/api_server.py


def translation(request: Request) -> OpenAIServingTranslation:
return request.app.state.openai_serving_translation
Copy link
Copy Markdown
Collaborator

@NickLucche NickLucche Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tink we're missing the instantiation of openai_serving_translation

vllm/entrypoints/openai/serving_transcription.py


class OpenAIServingTranscription(OpenAIServing):
class OpenAISpeechToText(OpenAIServing):
Copy link
Copy Markdown
Collaborator

@NickLucche NickLucche Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea factoring this out in a class

vllm/entrypoints/openai/serving_transcription.py
@@ -4,7 +4,7 @@
import time
Copy link
Copy Markdown
Collaborator

@NickLucche NickLucche Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this serving_speech_to_text.py now?

@DarkLight1337
Copy link
Copy Markdown
Member

DarkLight1337 commented Jul 15, 2025

Closing as superseded by #19615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLucche NickLucche NickLucche approved these changes

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm will be requested when the pull request is marked ready for review aarnphm is a code owner

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang chaunceyjiang will be requested when the pull request is marked ready for review chaunceyjiang is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 will be requested when the pull request is marked ready for review DarkLight1337 is a code owner

@russellb russellb Awaiting requested review from russellb russellb will be requested when the pull request is marked ready for review russellb is a code owner

Assignees

@ywang96 ywang96

Labels

frontend multi-modality Related to multi-modality (#4194)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ywang96 @mgoin @DarkLight1337 @NickLucche