Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Apr 1, 2025

v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[Qwen/Qwen2.5-1.5B-Instruct-guidance:disable-any-whitespace-auto] has been flaky on CI and therefore blocking quite a few PRs.

This PR disables this test temporarily to unblock other folks - see discussion https://vllm-dev.slack.com/archives/C07R5PAL2L9/p1743492042284569

cc @russellb @mgoin

Signed-off-by: Roger Wang <[email protected]>
@ywang96 ywang96 requested review from mgoin and russellb as code owners April 1, 2025 15:42
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 1, 2025
@mergify mergify bot added the v1 label Apr 1, 2025
@mgoin mgoin enabled auto-merge (squash) April 1, 2025 15:47
@mgoin mgoin merged commit 7e3f7a4 into main Apr 1, 2025
25 of 27 checks passed
@mgoin mgoin deleted the remove-guidance-CI branch April 1, 2025 17:42
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants