Skip to content

[V0][Minor] Support custom add a new kv connector without modify vllm code#15756

Closed
maobaolong wants to merge 3 commits intovllm-project:mainfrom
maobaolong:customConnector
Closed

[V0][Minor] Support custom add a new kv connector without modify vllm code#15756
maobaolong wants to merge 3 commits intovllm-project:mainfrom
maobaolong:customConnector

Conversation

@maobaolong
Copy link
Contributor

@maobaolong maobaolong commented Mar 29, 2025

The motivation of this PR aimed to make it easy to use a new kv connector implementation of third-party without modify vllm code.

In the other hand, vllm should not responsible for each custom kv connector implementations.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill added the v0 label Mar 31, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Jun 30, 2025
@mergify
Copy link

mergify bot commented Jun 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @maobaolong.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jun 30, 2025
@maobaolong
Copy link
Contributor Author

As this has been merged by #18142 , so I closed this PR, and thanks @sdavidbd for your PR.

@maobaolong maobaolong closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase stale Over 90 days of inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants