-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
implement prometheus fast-api-instrumentor for http service metrics #15657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement prometheus fast-api-instrumentor for http service metrics #15657
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
935e0d6 to
7293913
Compare
youngkent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
|
@simon-mo the package is actually already included requirements/common.txt I think will share load test results in PR description shortly |
|
@simon-mo @youngkent benchmark comparison added to PR description |
…llm-project#15657) Signed-off-by: xinyuxiao <[email protected]>
…llm-project#15657) Signed-off-by: Louis Ulmer <[email protected]>
PR vllm-project#15657 hooked up prometheus_fastapi_instrumentator but only for V0. Signed-off-by: Mark McLoughlin <[email protected]>
…llm-project#15657) Signed-off-by: Mu Huai <[email protected]>
track http level metrics such as requests counts by route/status code, request duration and request size using prometheus fast-api-instrumentor
benchmark serving results:
BEFORE:
AFTER: