Skip to content

Conversation

@daniel-salib
Copy link
Contributor

@daniel-salib daniel-salib commented Mar 28, 2025

track http level metrics such as requests counts by route/status code, request duration and request size using prometheus fast-api-instrumentor

benchmark serving results:

BEFORE:

Successful requests:                     32741     
Benchmark duration (s):                  651.08    
Total input tokens:                      7238749   
Total generated tokens:                  5967511   
Request throughput (req/s):              50.29     
Output token throughput (tok/s):         9165.57   
Total Token throughput (tok/s):          20283.64  
---------------Time to First Token----------------
Mean TTFT (ms):                          391076.36 
Median TTFT (ms):                        383066.19 
P99 TTFT (ms):                           582484.00 
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          70.28     
Median TPOT (ms):                        74.56     
P99 TPOT (ms):                           142.45    
---------------Inter-token Latency----------------
Mean ITL (ms):                           69.30     
Median ITL (ms):                         64.55     
P99 ITL (ms):                            102.58    

AFTER:

Successful requests:                     32740     
Benchmark duration (s):                  649.47    
Total input tokens:                      7238464   
Total generated tokens:                  5969746   
Request throughput (req/s):              50.41     
Output token throughput (tok/s):         9191.73   
Total Token throughput (tok/s):          20336.92  
---------------Time to First Token----------------
Mean TTFT (ms):                          402654.72 
Median TTFT (ms):                        402136.79 
P99 TTFT (ms):                           585043.95 
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          68.99     
Median TPOT (ms):                        63.16     
P99 TPOT (ms):                           142.45    
---------------Inter-token Latency----------------
Mean ITL (ms):                           66.58     
Median ITL (ms):                         56.28     
P99 ITL (ms):                            98.87     

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@daniel-salib daniel-salib force-pushed the fastapi-instrumentator branch from 935e0d6 to 7293913 Compare March 28, 2025 00:45
Copy link
Contributor

@youngkent youngkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@simon-mo
Copy link
Collaborator

  • Please add this to requirements txt
  • Please run load test

@daniel-salib
Copy link
Contributor Author

@simon-mo the package is actually already included requirements/common.txt I think

will share load test results in PR description shortly

@daniel-salib
Copy link
Contributor Author

@simon-mo @youngkent benchmark comparison added to PR description

@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2025
@simon-mo simon-mo enabled auto-merge (squash) March 28, 2025 22:00
@simon-mo simon-mo merged commit f3f8d8f into vllm-project:main Mar 29, 2025
43 of 44 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
markmc added a commit to markmc/vllm that referenced this pull request Apr 17, 2025
PR vllm-project#15657 hooked up prometheus_fastapi_instrumentator but
only for V0.

Signed-off-by: Mark McLoughlin <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants