Skip to content

[V1][Spec Decode] Remove deprecated spec decode config params #15466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2025
Merged

[V1][Spec Decode] Remove deprecated spec decode config params #15466

merged 6 commits into from
Mar 31, 2025

Conversation

@ShangmingCai
Copy link
Contributor

@ShangmingCai ShangmingCai commented Mar 25, 2025 •
edited by github-actions bot
Loading

This PR serves as a follow-up to PR #14434.

It removes the deprecated spec decode configuration parameters and stale warning code. Additionally, the JSON decode logic of speculative_config has been optimized. Some related docsring and tests have been updated as well to respect these changes.

CC: @LiuXiaoxuanPKU @comaniac

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

LiuXiaoxuanPKU
LiuXiaoxuanPKU reviewed Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link

mergify bot commented Mar 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ShangmingCai.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 29, 2025
@mergify mergify bot removed the needs-rebase label Mar 30, 2025
@LiuXiaoxuanPKU LiuXiaoxuanPKU added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 30, 2025
@ShangmingCai
minor, fix missed tests
39c34d5 
Signed-off-by: Shangming Cai <[email protected]>
@mergify mergify bot added documentation Improvements or additions to documentation ci/build v1 labels Mar 30, 2025
@ShangmingCai
fix model register test
0644ac4 
Signed-off-by: Shangming Cai <[email protected]>
@ShangmingCai
Copy link
Contributor Author

ShangmingCai commented Mar 31, 2025

@LiuXiaoxuanPKU I have fixed some missed tests, please check.

@ShangmingCai
Copy link
Contributor Author

ShangmingCai commented Mar 31, 2025

@DarkLight1337 Has v1-test been fixed on the main branch? If so, I will merge main to finish the CI.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Mar 31, 2025 •
edited
Loading

No it's not fixed. I can force-merge if necessary

@vllm-bot vllm-bot merged commit 239b7be into vllm-project:main Mar 31, 2025
38 of 40 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@ShangmingCai @Alex4210987
[V1][Spec Decode] Remove deprecated spec decode config params (vllm-p…
e0232f0 
…roject#15466)

Signed-off-by: Shangming Cai <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@ShangmingCai @lulmer
[V1][Spec Decode] Remove deprecated spec decode config params (vllm-p…
f0265bb 
…roject#15466)

Signed-off-by: Shangming Cai <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@ShangmingCai @lk-chen
[V1][Spec Decode] Remove deprecated spec decode config params (vllm-p…
52c272d 
…roject#15466)

Signed-off-by: Shangming Cai <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@ShangmingCai @shreyankg
[V1][Spec Decode] Remove deprecated spec decode config params (vllm-p…
bbd3909 
…roject#15466)

Signed-off-by: Shangming Cai <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ShangmingCai
[V1][Spec Decode] Remove deprecated spec decode config params (vllm-p…
02eeaa1 
…roject#15466)

Signed-off-by: Shangming Cai <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@calvin0327 calvin0327 mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiuXiaoxuanPKU LiuXiaoxuanPKU LiuXiaoxuanPKU approved these changes

@njhill njhill Awaiting requested review from njhill

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShangmingCai @DarkLight1337 @LiuXiaoxuanPKU @vllm-bot