Fix OpenAI ChatCompletion Ignore stop from FastChat Conv Template #1503
Closed
xingyaoww wants to merge 2 commits into
Closed
Fix OpenAI ChatCompletion Ignore stop from FastChat Conv Template #1503xingyaoww wants to merge 2 commits into
xingyaoww wants to merge 2 commits into
Conversation
Contributor
|
I replaced the implementation of this function already in: #1493 That should be the way to solve this anyways. FastChat is a hack for formatting. |
amy-why-3459
pushed a commit
to amy-why-3459/vllm
that referenced
this pull request
Sep 15, 2025
…t#1503) ### What this PR does / why we need it? This pull request introduces full-graph capture, replacing the previous piecewise-graph approach. Key improvements include: * **Reduced dispatch latency:** By capturing the entire model execution graph at once, we minimize overhead compared to multiple smaller captures. * **Stabilized multi-GPU performance:** Eliminates throughput fluctuations during the `MODEL_EXECUTE` phase across multiple cards. * **Stream resource savings:** Consolidating graph captures frees up streams, allowing more graphs to be captured concurrently. **Known issues:** 1. Capturing larger or more numerous graphs increases GPU memory usage, which can lead to OOM errors or inference hangs. 2. The new paged-attention implementation relies on the FIA operator, which in certain workloads is slower than the previous approach—resulting in a regression in end-to-end throughput. There may be other undiscovered corner cases. This PR is the first in a planned series; we will continue to iterate on and address any remaining issues in subsequent submissions. ### Does this PR introduce _any_ user-facing change? ```python compilation_config={ "full_cuda_graph": True, }, ``` ### How was this patch tested? --------- Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using vLLM's OpenAI API server to serve models, I find that the ChatCompletion request by default does not honor the
stop_token_idsandstop_strset by FastChat conversation templates. It will cause issues (model keep generating irrelevant stuff) when using vLLM served OpenAI API as an OpenAI compatible server for Gradio interface of FastChat.This PR add a check in OpenAI ChatCompletion request to make sure the
stop_token_idsandstop_strare merged with the request before send it to generation, similar to the implementation of FastChatvllm_worker.