Skip to content

[ROCm][AMD] Enable ROCm Flash Attention Backend for Encoder-Decoder Models#14803

Closed
vllmellm wants to merge 3 commits intovllm-project:mainfrom
EmbeddedLLM:rocm-encoder-decoder
Closed

[ROCm][AMD] Enable ROCm Flash Attention Backend for Encoder-Decoder Models#14803
vllmellm wants to merge 3 commits intovllm-project:mainfrom
EmbeddedLLM:rocm-encoder-decoder

Conversation

@vllmellm
Copy link
Contributor

@vllmellm vllmellm commented Mar 14, 2025

Description

This PR enables ROCm Flash Attention for ENCODER-DECODER models.

Testing

Locally ran tests:

  • vllm/tests/models/encoder_decoder/audio_language/test_whisper.py [Passed]
  • vllm/tests/encoder_decoder/test_e2e_correctness.py [Passed]
  • vllm/tests/models/encoder_decoder/vision_language/test_florence2.py [Passed]

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
@DarkLight1337 DarkLight1337 added the rocm Related to AMD ROCm label Mar 14, 2025
@mergify
Copy link

mergify bot commented Jul 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @vllmellm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 21, 2025
@hmellor
Copy link
Member

hmellor commented Mar 4, 2026

Closing as this was superseded by #35334 which enables encoder-decoder models on both ROCm and AITER unified attention backends. Thanks for the contribution!

@hmellor hmellor closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants