Skip to content

Enforce that TP > 1 is not supported for Mamba2 if Quantization is Enabled.#14617

Merged
tlrmchlsmth merged 2 commits intovllm-project:mainfrom
fabianlim:fix/quant
Mar 21, 2025
Merged

Enforce that TP > 1 is not supported for Mamba2 if Quantization is Enabled.#14617
tlrmchlsmth merged 2 commits intovllm-project:mainfrom
fabianlim:fix/quant

Conversation

@fabianlim
Copy link
Contributor

@fabianlim fabianlim commented Mar 11, 2025

Currently there is a bug in the logic that will fail to load the model if the mamba2 layer is quantised. This is because quantised layers have parameters of type ModelWeightParameter that do not allow the weight_loader to be modified, which is our current strategy of handling TP for the mamba2 in_proj, see #13660.

This PR prevents an Attribute Error

AttributeError: property 'weight_loader' of 'ModelWeightParameter' object has no deleter

from being thrown, in the case when using quant layers with TP=1. And also, it prevents TP > 2 from being used if quant layers are present

cc: @tlrmchlsmth

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) March 20, 2025 14:43
@tlrmchlsmth tlrmchlsmth merged commit 06dd082 into vllm-project:main Mar 21, 2025
34 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
…abled. (vllm-project#14617)

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…abled. (vllm-project#14617)

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
…abled. (vllm-project#14617)

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…abled. (vllm-project#14617)

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants