Skip to content

Support w8a8 block_fp8_matmul from generated kernel#13835

Closed
wenscarl wants to merge 1 commit intovllm-project:mainfrom
wenscarl:gen_kernel_w8a8_block_matmul
Closed

Support w8a8 block_fp8_matmul from generated kernel#13835
wenscarl wants to merge 1 commit intovllm-project:mainfrom
wenscarl:gen_kernel_w8a8_block_matmul

Conversation

@wenscarl
Copy link
Contributor

@wenscarl wenscarl commented Feb 25, 2025

A lightweight integration layer to enable w8a8_block_fp8_matmul support using the generated block FP8 matrix multiplication kernels.

Note: This kernel requires the scale factor to have a shape of [K/128, M], which is incompatible with the Triton equivalent. To resolve this, an implicit transpose is applied.

Performance Comparison of DeepSeek v3 on blackwell: Generated Kernel vs. Triton
Eager Mode
generated kernel: Throughput: 0.10 requests/s, 114.93 total tokens/s, 101.32 output tokens/s
Triton: Throughput: 0.09 requests/s, 103.54 total tokens/s, 91.28 output tokens/s
Graph Mode
generated kernel: Throughput: 0.14 requests/s, 162.16 total tokens/s, 142.97 output tokens/s
Triton: Throughput: 0.11 requests/s, 126.15 total tokens/s, 111.22 output tokens/s

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 25, 2025
@mergify
Copy link

mergify bot commented May 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wenscarl.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 29, 2025
@hmellor
Copy link
Member

hmellor commented Mar 4, 2026

Closing as the w8a8 block linear architecture has since been refactored (#33047, #33892, #33893). The generated kernels would need to be reworked to fit the new framework. Feel free to open a fresh PR if you'd like to integrate them. Thanks for the contribution!

@hmellor hmellor closed this Mar 4, 2026
@mergify mergify bot added the nvidia label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants