Skip to content

[Frontend] Remove custom_cache_manager#13791

Merged
jeejeelee merged 2 commits into
vllm-project:mainfrom
fulvius31:triton_cache
Mar 19, 2025
Merged

[Frontend] Remove custom_cache_manager#13791
jeejeelee merged 2 commits into
vllm-project:mainfrom
fulvius31:triton_cache

Conversation

@fulvius31
Copy link
Copy Markdown
Contributor

@fulvius31 fulvius31 commented Feb 24, 2025 •
edited
Loading

Remove custom_cache_manager since vllm uses torch 2.6.0 which uses triton 3.2.0 that includes triton-lang/triton#4295

cc @tdoublep @jeejeelee

@fulvius31
Remove custom_cache_manager
bf001cd 
since vllm uses torch 2.5.1
which uses triton 3.1.0
that includes triton-lang/triton#4295

Signed-off-by: Alessandro Sangiorgi <asangior@redhat.com>

Signed-off-by: fulvius31 <asangior@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee
Copy link
Copy Markdown
Collaborator

jeejeelee commented Feb 25, 2025

I am aware of this PR, but I haven't found this code in the triton/runtime/cache.py corresponding to 3.1.0, so I understand that the 3.1.0 triton might not include this PR yet.

@jeejeelee
Copy link
Copy Markdown
Collaborator

jeejeelee commented Feb 25, 2025

torch 2.6.0 will install triton 3.2.0, which looks include triton-lang/triton#4295. Therefore, we can consider this PR after #12721 is merged.

@fulvius31
Copy link
Copy Markdown
Contributor Author

fulvius31 commented Feb 25, 2025

I am aware of this PR, but I haven't found this code in the triton/runtime/cache.py corresponding to 3.1.0, so I understand that the 3.1.0 triton might not include this PR yet.

You are totally right!
I faced the cache issue on 3.0.0 and then when I updated to 3.1.0 the issue was gone. Then I checked quickly (too quick) the cache.py code and I thought it was merged already.

Let's wait #12721 !

@jeejeelee
Copy link
Copy Markdown
Collaborator

jeejeelee commented Mar 15, 2025

@fulvius31 FYI #12721 has been merged

@fulvius31
Copy link
Copy Markdown
Contributor Author

fulvius31 commented Mar 15, 2025

@fulvius31 FYI #12721 has been merged

Thanks for letting me know @jeejeelee !

I just synced the branch with the last commit!

@fulvius31
Copy link
Copy Markdown
Contributor Author

fulvius31 commented Mar 15, 2025

@jeejeelee I do think that - since torch 2.6.0 will be part of the v0.8.0 - we can include also this PR to this new vLLM version.

CC @simon-mo

@jeejeelee jeejeelee mentioned this pull request Mar 19, 2025
Closed
1 task
jeejeelee
jeejeelee approved these changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually worried about the possibility of reverting the torch version. Now we should be able to delete these. Thank you very much.

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2025
@jeejeelee jeejeelee merged commit 374ee28 into vllm-project:main Mar 19, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@fulvius31 @lulmer
[Frontend] Remove custom_cache_manager (vllm-project#13791)
be98894 
Signed-off-by: fulvius31 <asangior@redhat.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
@fulvius31 fulvius31 deleted the triton_cache branch May 2, 2025 21:41
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@fulvius31 @shreyankg
[Frontend] Remove custom_cache_manager (vllm-project#13791)
c830244 
Signed-off-by: fulvius31 <asangior@redhat.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@fulvius31
[Frontend] Remove custom_cache_manager (vllm-project#13791)
d0fe557 
Signed-off-by: fulvius31 <asangior@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fulvius31 @jeejeelee