-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[Misc] Warn if the vLLM version can't be retrieved #13501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Warn if the vLLM version can't be retrieved #13501
Conversation
Signed-off-by: Alex-Brooks <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Alex-Brooks <[email protected]>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @youkaichao
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
There are a few checks that vLLM runs when inferring the platform that rely on inspecting the version of the vLLM package (i.e., via
importlib.metadata.version). If the vLLM package isn't installed though, the import error will be swallowed, and it can result in the platform not being undetectable. There are a few situations in which this could happen, e.g., running vLLM in a dev environment where the source was been cloned & shared objects were copied from a release, but the project is just on the python path instead of installed into site packages.This PR wraps the calls to
version("vllm")to warn if aPackageNotFoundErroris thrown to try to help make it more clear if this is the cause of platform resolution failing, e.g.,