[Do not merge] Hacks for the ROCm port#1314
Closed
pcmoritz wants to merge 17 commits into
Closed
Conversation
Contributor
|
@pcmoritz I'd like to submit a pull request to replace the usage of HIP API for type conversions for Float16 with ASM volatile instructions. Additionally, I've modified the setup.py file to check for the availability of ROCMHOME, and if it is set, the flags are updated to include -DUSE_ROCM. Would appreciate it if you could review the pull request and let me know if there are any issues or concerns. Thanks! |
Collaborator
WeNeedMoreCode
pushed a commit
to WeNeedMoreCode/vllm
that referenced
this pull request
Dec 15, 2025
Add codespell check test for doc only PR Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is getting tests working on top of #1313
Currently the following tests are working:
kernels/test_activation.pykernels/test_cache.pykernels/test_layernorm.pykernels/test_pos_encoding.pyCurrently, the following test is failing:
kernels/test_attention.pywith