Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: <>
|
Qwen shares the same architecture with Qwen-VL so I'd like to keep at least one test to check that the text-only version works correctly (there have been regressions in the past due to updating Qwen-VL) |
okay I just reverted |
We need to load the Qwen (V1) model specifically, at least untilr #13157 is merged - afterwards we should be free to remove the test outright. |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: kevin <kevin@anyscale.com>
| "OrionStarAI/Orion-14B-Chat": PPTestSettings.fast(), | ||
| "adept/persimmon-8b-chat": PPTestSettings.fast(), | ||
| "microsoft/phi-2": PPTestSettings.fast(), | ||
| "Qwen/Qwen2.5-1.5B-Instruct": PPTestSettings.fast(), |
There was a problem hiding this comment.
Can we keep this in alphabetical order (by model architecture)? Also, the test isn't actually run unless you include the model name in TEST_MODELS
| @@ -47,7 +47,7 @@ | |||
| marks=[pytest.mark.core_model], | |||
| ), | |||
| pytest.param( | |||
|
This pull request has merge conflicts that must be resolved before it can be |
|
I guess this isn't necessary anymore? |
|
yep let me close the PR
|
Try to convert as many Qwen and Qwen2 to Qwen2.5 and reduce model size as we can.