Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLM] Merged multi-modal processors for LLaVA-NeXT-Video and LLaVA-OneVision #11717

Merged
merged 19 commits into from
Jan 4, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix processor tests
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337 committed Jan 4, 2025
commit ea6b7b46815fb243a9c3ddbe0788656134090000
Original file line number Diff line number Diff line change
@@ -54,5 +54,5 @@ def test_processor_prompt_replacements(

# NOTE: There is a BOS token
assert first_placeholder["offset"] == 1
assert first_placeholder["length"] + 1 == len(
processed_inputs["prompt_token_ids"]) // num_imgs
assert first_placeholder["length"] == (
len(processed_inputs["prompt_token_ids"]) - 1) // num_imgs
Original file line number Diff line number Diff line change
@@ -54,6 +54,6 @@ def test_processor_prompt_replacements(
first_placeholder = image_placeholders[0]

# NOTE: There is a BOS token
assert first_placeholder["offset"] == 1
assert first_placeholder["length"] + 1 == len(
assert first_placeholder["offset"] == 0
assert first_placeholder["length"] == len(
processed_inputs["prompt_token_ids"]) // num_imgs