Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Expand test_guided_generate to test all backends #11313

Merged

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Dec 19, 2024

Previously we were only testing the default structured output backend, so we should expand to explicitly call all backends. This revealed some lack of support in outlines for json_object and lm-format-enforcer for regex patterns in json schemas.

I also found some of the tests are flaky for some backends due to bad model output (many many newlines or filler tokens), so using a higher quality Qwen2.5 model helped

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 19, 2024 02:32
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 19, 2024
@DarkLight1337 DarkLight1337 merged commit a30482f into vllm-project:main Dec 19, 2024
67 of 68 checks passed
ZenPuzzle pushed a commit to ZenPuzzle/vllm that referenced this pull request Dec 25, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants