Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch.compile] add warning for unsupported models #10622

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member Author

this completes the user-facing work of torch.compile:

for unsupported features like lora and cpu offloading, we will turn off torch.compile ;

for unsupported models like encoder-decoder models, we will print a warning message.

Signed-off-by: youkaichao <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 25, 2024 07:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 25, 2024
@youkaichao
Copy link
Member Author

locally tested & we don't have tests for it in the ci.

@youkaichao youkaichao merged commit 6581378 into vllm-project:main Nov 25, 2024
16 of 23 checks passed
@youkaichao youkaichao deleted the not_compiled_model branch November 25, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants