Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc]Further reduce BNB static variable #10597

Merged
merged 19 commits into from
Nov 27, 2024
Merged

[Misc]Further reduce BNB static variable #10597

merged 19 commits into from
Nov 27, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Nov 24, 2024 •
edited by github-actions bot
Loading

I have tested these changes locally using llama/mllama/minicpmv2.6/qwen.25/phi-3, all can generate reasonable results.
Thanks to @Isotr0py for his previous work, which made this PR easier.

@jeejeelee jeejeelee marked this pull request as draft November 24, 2024 02:18
@jeejeelee jeejeelee changed the title [Misc]Further reduce BNB static variabl [Misc]Further reduce BNB static variable Nov 24, 2024
@mergify Mergify
Copy link

mergify bot commented Nov 24, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 24, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Address branch conflict
d503512 
Signed-off-by: Jee Jee Li <[email protected]>
@mergify mergify bot removed the needs-rebase label Nov 25, 2024
@jeejeelee jeejeelee marked this pull request as ready for review November 26, 2024 08:45
@jeejeelee jeejeelee requested a review from mgoin November 26, 2024 08:45
mgoin
mgoin approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work I think this is a clear improvement! I just have a nit on the function name

vllm/model_executor/model_loader/loader.py Outdated Show resolved Hide resolved
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 26, 2024
@jeejeelee jeejeelee requested a review from mgoin November 27, 2024 00:09
@jeejeelee
Copy link
Collaborator Author

@mgoin It looks like the CI failure is unrelated to this PR, maybe we need to force merge?

@Isotr0py Isotr0py mentioned this pull request Nov 27, 2024
Merged
@youkaichao youkaichao merged commit 15cc2a9 into vllm-project:main Nov 27, 2024
46 of 48 checks passed
@jeejeelee jeejeelee deleted the delete-bnb-staic-var branch November 27, 2024 07:03
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@jeejeelee @afeldman-nm
[Misc]Further reduce BNB static variable (vllm-project#10597)
a809ee1 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@jeejeelee
[Misc]Further reduce BNB static variable (vllm-project#10597)
cd3a6f3 
Signed-off-by: Jee Jee Li <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@jeejeelee @BKitor
[Misc]Further reduce BNB static variable (vllm-project#10597)
6a7a0e0 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee mentioned this pull request Jan 22, 2025
Open
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
@jeejeelee @anko-intel
[Misc]Further reduce BNB static variable (vllm-project#10597)
731b291 
Signed-off-by: Jee Jee Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeejeelee @mgoin @youkaichao