Skip to content

🐛 put decode back in warmup#293

Merged
yannicks1 merged 2 commits intomainfrom
fix-indents
Jul 9, 2025
Merged

🐛 put decode back in warmup#293
yannicks1 merged 2 commits intomainfrom
fix-indents

Conversation

@joerunde
Copy link
Copy Markdown
Collaborator

@joerunde joerunde commented Jul 9, 2025

Description

Fixes a bug introduced in #283 where the decode pass was moved out of the warmup context.

AKA: @prashantgupta24's editor likes to unindent things, and @joerunde likes to view diffs with whitespace changes ignored, so here we are 😅

Signed-off-by: Joe Runde <joe@joerun.de>
@joerunde
Copy link
Copy Markdown
Collaborator Author

joerunde commented Jul 9, 2025

bot:test
MARKERS="cb and spyre"

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Joe Runde <joe@joerun.de>
Copy link
Copy Markdown
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, would be great if it was just an indention problem

@prashantgupta24
Copy link
Copy Markdown
Collaborator

Added to #292

@yannicks1 yannicks1 merged commit a7066d9 into main Jul 9, 2025
18 checks passed
@yannicks1 yannicks1 deleted the fix-indents branch July 9, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants