Repository navigation
[CI/Build] Fix vLLM 0.33 AMD regressions #9883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andyluo7
merged 5 commits into
vllm-project:main
from
lm10-arg:fix/vllm033-ci-regressions-20261104
Nov 4, 2026
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
80276c5
[CI/Build] Fix vLLM 0.33 AMD regressions
lm10-arg fe17e44
[CI/Build] Use portable Triton libdevice for MOSS
andyluo7 349fbf1
[CI/Build] Gate MOSS round-to-nearest op to CUDA
andyluo7 13a4c72
[CI/Build] Make TheRock library discovery deterministic
andyluo7 4e7f3c9
[CI/Build] Refresh ROCm R2 collection guard
andyluo7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM-Omni project | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import subprocess | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
| pytestmark = [pytest.mark.core_model, pytest.mark.cpu] | ||
|
|
||
|
|
||
| def test_local_tools_package_wins_over_later_regular_package(tmp_path: Path) -> None: | ||
| repo_root = Path(__file__).resolve().parents[2] | ||
| competing_root = tmp_path / "dependency" | ||
| competing_package = competing_root / "tools" | ||
| competing_package.mkdir(parents=True) | ||
| (competing_package / "__init__.py").write_text("SOURCE = 'dependency'\n", encoding="utf-8") | ||
|
|
||
| environment = os.environ.copy() | ||
| environment["PYTHONPATH"] = os.pathsep.join((str(repo_root), str(competing_root))) | ||
| program = "from pathlib import Path; import tools; print(Path(tools.__file__).resolve())" | ||
| completed = subprocess.run( | ||
| [sys.executable, "-c", program], | ||
| cwd=tmp_path, | ||
| env=environment, | ||
| check=True, | ||
| capture_output=True, | ||
| text=True, | ||
| timeout=10, | ||
| ) | ||
|
|
||
| assert Path(completed.stdout.strip()) == (repo_root / "tools/__init__.py").resolve() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM-Omni project | ||
|
|
||
| """Repository-local developer and CI tools. | ||
|
|
||
| Making this directory a regular package prevents a dependency's top-level | ||
| ``tools`` package from shadowing these modules when the repository root appears | ||
| first on ``sys.path``. | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.