-
Notifications
You must be signed in to change notification settings - Fork 950
[Feature] Support Stage Based Deployment CLI #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
467e351
stage cli
wuhang2014 4236948
update test
wuhang2014 980827c
test fix
wuhang2014 1d15991
test fix
wuhang2014 e2323d7
test fix
wuhang2014 49660cc
test fix
wuhang2014 87b804a
test fix
wuhang2014 b2ff7ee
test fix
wuhang2014 4823b78
test fix
wuhang2014 480f94d
test fix
wuhang2014 bd4f089
test fix
wuhang2014 5df7c98
test fix
wuhang2014 3f3b9ec
test fix
wuhang2014 80b77cc
test fix
wuhang2014 1422e0e
test fix
wuhang2014 8ea892a
test fix
wuhang2014 7710f5e
test fix
wuhang2014 91e7959
test fix
wuhang2014 94d271b
test fix
wuhang2014 925a2af
test fix
wuhang2014 b16e8f3
test fix
wuhang2014 42df8d7
test fix
wuhang2014 fdfa87f
test fix
wuhang2014 18f9373
fix test
wuhang2014 cc9bd9e
fix some bug (#3)
princepride e1e50f8
update for review suggestions
wuhang2014 df6019d
Update vllm_omni/entrypoints/cli/serve.py
wuhang2014 4d047d2
Update examples/online_serving/bagel/run_server_stage_cli.sh
wuhang2014 b8b02a8
Update vllm_omni/entrypoints/omni.py
wuhang2014 f2a82a2
thread join order
wuhang2014 c05ecb4
import ordering
wuhang2014 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| #!/bin/bash | ||
| # Bagel multi-stage online serving startup script | ||
| # Starts stage 0 as master with API server, and stage 1 in headless mode | ||
|
|
||
| MODEL="${MODEL:-ByteDance-Seed/BAGEL-7B-MoT}" | ||
| PORT="${PORT:-8091}" | ||
| MASTER_ADDRESS="${MASTER_ADDRESS:-127.0.0.1}" | ||
| MASTER_PORT="${MASTER_PORT:-8092}" | ||
| STAGE_CONFIGS_PATH="$(dirname "$0")/../../../vllm_omni/model_executor/stage_configs/bagel.yaml" | ||
|
|
||
| echo "Starting Bagel multi-stage server..." | ||
| echo "Model: $MODEL" | ||
| echo "API Port: $PORT" | ||
| echo "Master Address: $MASTER_ADDRESS" | ||
| echo "Master Port: $MASTER_PORT" | ||
| echo "Stage Configs: $STAGE_CONFIGS_PATH" | ||
|
|
||
| # Start stage 1 (DiT) in headless mode first | ||
| echo "Starting Stage 1 (DiT) in headless mode..." | ||
| vllm serve "$MODEL" --omni \ | ||
| --stage-configs-path "$STAGE_CONFIGS_PATH" \ | ||
| --stage-id 1 \ | ||
| --headless \ | ||
| -oma "$MASTER_ADDRESS" \ | ||
| -omp "$MASTER_PORT" & | ||
|
Comment on lines
+24
to
+25
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's best to use the full name here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's OK, one can search the code for full name. The short name is more easy for typing.
wuhang2014 marked this conversation as resolved.
|
||
|
|
||
| # Start stage 0 (Thinker) as master with API server | ||
| echo "Starting Stage 0 (Thinker) as master..." | ||
| vllm serve "$MODEL" --omni \ | ||
| --port "$PORT" \ | ||
| --stage-configs-path "$STAGE_CONFIGS_PATH" \ | ||
| --stage-id 0 \ | ||
| -oma "$MASTER_ADDRESS" \ | ||
| -omp "$MASTER_PORT" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,3 +14,4 @@ imageio[ffmpeg]>=2.37.2 | |
| sox>=1.5.0 | ||
| prettytable>=3.8.0 | ||
| aenum==3.1.16 | ||
| pyzmq>=25.0.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we init stage 1 first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, which stage init first is OK