Repository navigation
[NPU] upgrade to v0.32.0 - #9143
Conversation
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR matches CODEOWNERS paths: /docs/, /tests/. Code owners: @david6666666 @Gaohan123 @hsliuustc0106 Routing: @david6666666 via CODEOWNERS; @Gaohan123 via CODEOWNERS; @hsliuustc0106 via CODEOWNERS @FayeSpica, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
yenuo26
left a comment
There was a problem hiding this comment.
The NPU release install snippet now pulls vLLM-Ascend v0.32.0 and still clones Omni v0.30.0. Those two do not share a transformers range.
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.32.0 | ||
| ``` | ||
|
|
||
| === "A3" | ||
|
|
||
| ```bash | ||
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.31.0-a3 | ||
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.32.0-a3 | ||
| ``` | ||
|
|
||
| === "A5" | ||
|
|
||
| ```bash | ||
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.31.0-a5 | ||
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.32.0-a5 | ||
| ``` | ||
|
|
||
| === "310P (Experimental)" | ||
|
|
||
| ```bash | ||
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.31.0-310p | ||
| export IMAGE=quay.io/atlas-ci/vllm-ascend:v0.32.0-310p |
There was a problem hiding this comment.
The NPU release tab now pulls quay.io/atlas-ci/vllm-ascend:v0.32.0 (and -a3 / -a5 / -310p), but the same snippet still runs git clone -b v0.30.0 at line 56.
Omni v0.30.0 pins transformers>=5.13.0,<5.15 for vLLM 0.30.0. This checkout requires transformers>=5.16.1,<5.20.0 for vLLM 0.32.0, and that <5.15 cap conflicts with the 5.16+ APIs. pip install -e . inside this image pulls transformers back below 5.15.
Move these v0.32.0 image exports into the "NPU from main" section, which clones current main. Keep the release snippet on the Ascend image that matches the v0.30.0 checkout.
There was a problem hiding this comment.
Thanks! Reverted the installation doc changes in b530b92.
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
…shes Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com> Co-authored-by: wangyu <53896905+yenuo26@users.noreply.github.com>
Contributor intent (required human answers)
1. What outcome do you want to achieve?
Upgrade the Ascend CI base image to v0.32.0 and keep CI working.
2. What is the highest-leverage variable for that outcome?
Compatibility between Omni and the vLLM v0.32.0 / vLLM-Ascend stack.
3. How will this work move that variable?
Update the base image, installation examples, CI dependencies and KV-cache test fixture.
4. Whose customer or user needs does this address, and what are those needs?
Ascend users and contributors who need working inference and reliable CI on v0.32.0.
Purpose
Fix #9139.
Upgrade the Ascend base image from v0.31.0 to v0.32.0 in both NPU Dockerfiles and the A2/A3/A5/310P installation examples.
Test Plan
vLLM Version: v0.32.0.
vLLM-Omni Commit:
da572cddb38383deae9caef33b8d490e292ef071.vLLM-Ascend Image:
quay.io/atlas-ci/vllm-ascend:v0.32.0.python -m pytest -s -v tests/platforms/npu/test_contiguous_kv_cache.py -m 'core_model and npu and A3 and omni' --run-level core_modelpython -m pytest -s -v tests/e2e/online_serving/test_hunyuan_image.py -m 'core_model and diffusion and npu' --run-level core_modelpython examples/offline_inference/text_to_speech/qwen3_tts/end2end.py -q CustomVoice --num-prompts 1 --output-dir /tmp/val/tts/outpython examples/offline_inference/qwen3_omni/end2end.py --query-type use_audio --output-wav /tmp/val/omni/out --stage-init-timeout 600python examples/offline_inference/text_to_video/text_to_video.py --model Wan-AI/Wan2.2-TI2V-5B-Diffusers --prompt "Two anthropomorphic cats in boxing gear fight on a spotlighted stage." --height 480 --width 832 --num-frames 17 --num-inference-steps 8 --fps 16 --output /tmp/val/wan/t2v_out.mp4Test Result
AI Assistance
Codex assisted with code, regression checks and this draft. Human review remains required.
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
Note
To avoid agent spam, vLLM-Omni limits contributors without write access to 5 open PRs. If this blocks well-intentioned critical work, please contact a committer to request bypass list access.
(anything written below this line will be removed by GitHub Actions)