Skip to content

[Core] Allow Broadcasting Scalars - #9021

Merged
NickCao merged 1 commit into
vllm-project:mainfrom
alex-jw-brooks:broadcast-scalar-mm-outputs
Oct 20, 2026
Merged

NickCao merged 1 commit into
vllm-project:mainfrom
alex-jw-brooks:broadcast-scalar-mm-outputs

Conversation

@alex-jw-brooks

@alex-jw-brooks alex-jw-brooks commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Contributor intent (required human answers)

1. What outcome do you want to achieve?

I am trying to standardize the output of sampling rates formats across models, since we will need to standardize the key for audio watermarking to be effective: #7366, since audioseal needs to be able to get the sampling rate.

2. What is the highest-leverage variable for that outcome?

more uniformity across audio output models, broader coverage for audio watermarking once 7366 is merged, better alignment with serialization behaviors for mrv1 & v2.

3. How will this work move that variable?

Allows us to just emit the sampling rate etc as an int for models running on mrv1.

4. Whose customer or user needs does this address, and what are those needs?

Most users, since this is partially cleanup and partially in support of watermarking

Purpose

This PR is related to make the PR to make sampling rate more standardized, because currently the MRv1 integration (default) doesn't broadcast scalars. It would be nice to handle this correctly so that we can just emit an int instead of hacks like wrapping it in a 0d tensor. the sampling rate PR will touch a lot of files, so it would be nice to do this first.

Test Plan

Tests added. This code is also very much on the hot path for audio models

vLLM Version: 0.31
vLLM-Omni Commit: ebe2c18

Test Result

Tests pass, ints are handled in payload building.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-16T08:50:37.569966Z 1a7ab61 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vllm-omni-review-bot

Copy link
Copy Markdown

This PR appears to belong to: docs/design/module/execution_platforms.md, docs/design/module/ar_runtime.md, docs/design/module/diffusion/index.md.

Module owners: @gcanlin @tzhouam @david6666666

Routing: @gcanlin via module of the changed files, CODEOWNERS; @tzhouam via module of the changed files, CODEOWNERS; @david6666666 via module of the changed files

@alex-jw-brooks, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

@hsliuustc0106 hsliuustc0106 added the core related to core module: cache, scheduler, engine, worker, modelrunner label Oct 17, 2026
@hsliuustc0106 hsliuustc0106 added the high priority high priority issue, needs to be done asap label Oct 17, 2026 — with ChatGPT Codex Connector

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1a7ab6195447d360bb689c4779c7d8a352f6b9dd.

The shared-scalar handling preserves request boundaries: waveform lists remain per request, while sample-rate metadata reaches both payloads. On the server, the four targeted tests passed, and a production-helper → GPU worker scalar conversion → payload partition check preserved distinct waveforms plus int, float, bool, and zero-dimensional tensor values. The ndim > 0 guard also covers zero-dimensional metadata on the cached-output path. I found no blocking issue in these changes. Connector/wire roundtrip and full serving E2E were not tested.

Signed-off-by: Alex Brooks <albrooks@redhat.com>
@alex-jw-brooks
alex-jw-brooks force-pushed the broadcast-scalar-mm-outputs branch from 1a7ab61 to e0fc229 Compare October 20, 2026 17:10
@alex-jw-brooks alex-jw-brooks added the ready label to trigger buildkite CI label Oct 20, 2026
@NickCao
NickCao merged commit fe15c4c into vllm-project:main Oct 20, 2026
9 of 11 checks passed
ZhengWG pushed a commit to ZhengWG/vllm-omni that referenced this pull request Oct 21, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core related to core module: cache, scheduler, engine, worker, modelrunner high priority high priority issue, needs to be done asap ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants