[khairulkabir1661]

Summary

Guard --stage-init-timeout, --init-timeout, and --log-stats behind the use_omni flag in the test helper iter_omni_server.

Previously these omni-specific CLI args were always appended to server_args, causing non-omni servers (e.g. Whisper with use_omni=False) to fail with unknown-argument errors.

Changes

• tests/helpers/runtime.py: nest timeout and log-stats args inside if params.use_omni: block

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-15T01:39:59.952770Z	c5769a6	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[vllm-omni-review-bot]

This PR matches CODEOWNERS paths: /tests/.

Code owners: @NickCao @yenuo26

Routing: @NickCao via CODEOWNERS; @yenuo26 via CODEOWNERS

@khairulkabir1661, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

[vllm-omni-review-bot]

Omni ReviewBot: superseded

The CI failure noted on 6f4659919145 refers to an earlier head; the pull request now points at d6985c03f24b.

[vllm-omni-review-bot]

Omni ReviewBot: superseded

The CI failure noted on d6985c03f24b refers to an earlier head; the pull request now points at 27628a1b8a63.

[hsliuustc0106]

• Add a focused CPU regression for the argument assembly in iter_omni_server, and record the command/results on baseline da572cddb38383deae9caef33b8d490e292ef071 and this head. With use_omni=False, capture the arguments passed to the server and assert none of the three Omni-only flags is auto-added; with use_omni=True, retain default/custom timeouts and the explicit --disable-log-stats behavior. The non-Omni assertion should fail before this change and pass after it. This is the missing evidence for the unknown-argument fix, not a new code defect; the existing stage-CLI fixture test only asserts deploy-config handling. Author: khairulkabir1661. I inspected the source but did not execute these tests.

[khairulkabir1661]

CPU regression test results

Baseline da572cddb — 1 FAILED

tests/helpers/tests/test_runtime_omni_args.py::test_non_omni_skips_omni_flags FAILED
tests/helpers/tests/test_runtime_omni_args.py::test_omni_defaults PASSED
tests/helpers/tests/test_runtime_omni_args.py::test_omni_custom_timeouts PASSED
tests/helpers/tests/test_runtime_omni_args.py::test_omni_disable_log_stats_wins PASSED

FAILED test_non_omni_skips_omni_flags - AssertionError:
  Omni-only flags leaked into non-Omni args: {'--log-stats', '--init-timeout', '--stage-init-timeout'}

1 failed, 3 passed

Head 883c2984c — 4 passed

tests/helpers/tests/test_runtime_omni_args.py::test_non_omni_skips_omni_flags PASSED
tests/helpers/tests/test_runtime_omni_args.py::test_omni_defaults PASSED
tests/helpers/tests/test_runtime_omni_args.py::test_omni_custom_timeouts PASSED
tests/helpers/tests/test_runtime_omni_args.py::test_omni_disable_log_stats_wins PASSED

4 passed

Command

python -m pytest tests/helpers/tests/test_runtime_omni_args.py -v