Skip to content

[Bugfix] Wire output buffers into duplex model test harnesses #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyluo7 merged 1 commit into from
Oct 4, 2026
Merged

[Bugfix] Wire output buffers into duplex model test harnesses #8489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions tests/engine/duplex/test_session_runner_nemotron_voicechat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from vllm_omni.config.stage_config import DuplexSessionRuntimeConfig
from vllm_omni.engine.duplex import commands
from vllm_omni.engine.duplex.config import DuplexSessionConfig
from vllm_omni.engine.duplex.delivery import DuplexOutputBuffer
from vllm_omni.engine.duplex.messages import OpenDuplexSessionMessage
from vllm_omni.engine.duplex.plugin import load_duplex_plugin
from vllm_omni.engine.duplex.session.manager import DuplexSessionManager
Expand Down Expand Up @@ -57,20 +58,36 @@ async def harness(monkeypatch):
port = RecordingStagePort(stage_count=3)
output: asyncio.Queue = asyncio.Queue()
results: asyncio.Queue = asyncio.Queue()
limits = DuplexSessionRuntimeConfig()
output_buffer = DuplexOutputBuffer(
max_bytes=limits.max_pending_output_bytes_per_session,
max_events=limits.max_pending_output_events_per_session,
)
manager = DuplexSessionManager(
plugin=plugin,
stage_port=port,
output_sink=output,
result_sink=results,
runtime_config=DuplexSessionRuntimeConfig(),
runtime_config=limits,
model_config=SimpleNamespace(hf_config=SimpleNamespace(stt_cfg={}), max_model_len=8192),
)
try:
config = DuplexSessionConfig(model="nemotron", instructions="hi", extra_body={"auto_response": True})
await manager.handle(OpenDuplexSessionMessage(control_id="open", session_id=SESSION_ID, session_config=config))
await manager.handle(
OpenDuplexSessionMessage(
control_id="open", session_id=SESSION_ID, session_config=config, output_buffer=output_buffer
)
)
result = await asyncio.wait_for(results.get(), timeout=2)
assert result.ok, result
h = Harness(manager, port, output, results, manager.runners[SESSION_ID])
h = Harness(
manager=manager,
port=port,
output=output,
output_buffer=output_buffer,
results=results,
runner=manager.runners[SESSION_ID],
)
await h.settle()
yield h
finally:
Expand Down
23 changes: 20 additions & 3 deletions tests/engine/duplex/test_session_runner_personaplex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from vllm_omni.config.stage_config import DuplexSessionRuntimeConfig
from vllm_omni.engine.duplex import commands
from vllm_omni.engine.duplex.config import DuplexSessionConfig
from vllm_omni.engine.duplex.delivery import DuplexOutputBuffer
from vllm_omni.engine.duplex.messages import DuplexControlResultMessage, OpenDuplexSessionMessage
from vllm_omni.engine.duplex.session.manager import DuplexSessionManager
from vllm_omni.model_executor.models.personaplex.duplex import stage0
Expand All @@ -55,12 +56,17 @@ async def open_personaplex_harness(*, extra_body: dict[str, object] | None = Non
port = RecordingStagePort(stage_count=2)
output: asyncio.Queue[Any] = asyncio.Queue()
results: asyncio.Queue[Any] = asyncio.Queue()
limits = DuplexSessionRuntimeConfig()
output_buffer = DuplexOutputBuffer(
max_bytes=limits.max_pending_output_bytes_per_session,
max_events=limits.max_pending_output_events_per_session,
)
manager = DuplexSessionManager(
plugin=plugin,
stage_port=port,
output_sink=output,
result_sink=results,
runtime_config=DuplexSessionRuntimeConfig(),
runtime_config=limits,
model_config=SimpleNamespace(model="/models/personaplex-7b-v1"),
)
config = DuplexSessionConfig(
Expand All @@ -70,10 +76,21 @@ async def open_personaplex_harness(*, extra_body: dict[str, object] | None = Non
voice="NATF2.pt",
extra_body=dict(extra_body or {}),
)
await manager.handle(OpenDuplexSessionMessage(control_id="c-open", session_id=SESSION_ID, session_config=config))
await manager.handle(
OpenDuplexSessionMessage(
control_id="c-open", session_id=SESSION_ID, session_config=config, output_buffer=output_buffer
)
)
result = await asyncio.wait_for(results.get(), timeout=2.0)
assert isinstance(result, DuplexControlResultMessage) and result.ok, result
harness = Harness(manager=manager, port=port, output=output, results=results, runner=manager.runners[SESSION_ID])
harness = Harness(
manager=manager,
port=port,
output=output,
output_buffer=output_buffer,
results=results,
runner=manager.runners[SESSION_ID],
)
await harness.settle()
return harness

Expand Down
Loading