Repository navigation
[Bugfix] Initialize eager state in Higgs test fixture - #8426
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nick Cao <ncao@redhat.com>
|
This PR appears to belong to: docs/design/module/model_integration.md. Module owners: @gcanlin @tzhouam @yenuo26 Routing: @gcanlin via semantic router; @tzhouam via semantic router; @yenuo26 via CODEOWNERS @NickCao, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot routing recordAssigned Strict on cursor (cursor-grok-4.6-high) under experiment |
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Nick Cao <ncao@redhat.com>
NickCao
added
ready
Sy0307
enabled auto-merge (squash)
October 2, 2026 14:12
Collaborator
Author
|
Github auto-merge is stuck again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CI after #8259
#8259 added a call to
_eager_state.resume_audio()inOmniModelState.add_request. Normal construction initializes_eager_state, but the Higgs tests useobject.__new__, which skips that initialization.#8259’s passing CI didn’t cover this combination: its checked PR head lacked the Higgs test file introduced by #8226, The PR histories diverged at
e34f8c4, so the test and the newresume_audiocall weren’t together in the tested tree.Test Plan
vLLM Version: 0.30.0
vLLM-Omni Commit: c6a5b47
test-ready should now pass.
Test Result
Running