Skip to content

[Tests] Fix Qwen3-Omni E2E LiveKit Test - #8294

Merged
NickCao merged 2 commits into
vllm-project:mainfrom
forty-thousand-wasps:fix-qwen3-omni
Sep 29, 2026
Merged

NickCao merged 2 commits into
vllm-project:mainfrom
forty-thousand-wasps:fix-qwen3-omni

Conversation

@forty-thousand-wasps

Copy link
Copy Markdown
Contributor

Purpose

Fixes #8276

Test Plan

pytest -s -v tests/entrypoints/ -m "advanced_model and cuda and H100" --run-level "advanced_model" --deselect tests/entrypoints/openai_api/test_qwen3_omni_realtime_websocket.py::TestQwen3OmniRealtimeWebSocket::test_server_vad_multi_turn_without_client_commit

vLLM Version: 0.30.0

vLLM-Omni Commit: 4321e6d

Test Result

passed 😸

BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.

Note

To avoid agent spam, vLLM-Omni limits contributors without write access to 5 open PRs. If this blocks well-intentioned critical work, please contact a committer to request bypass list access.
(anything written below this line will be removed by GitHub Actions)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: vraiti <vraiti@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: vraiti <vraiti@redhat.com>
@vllm-omni-review-bot

Copy link
Copy Markdown

This PR appears to be related to model: qwen-omni.

Model owners: @amy-why-3459 @NickCao @yenuo26

Routing: @amy-why-3459 via semantic router; @NickCao via CODEOWNERS; @yenuo26 via CODEOWNERS

@vraiti, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

@NickCao NickCao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@NickCao NickCao added the ready label to trigger buildkite CI label Sep 29, 2026
@vllm-omni-review-bot

Copy link
Copy Markdown
Omni ReviewBot routing record

Assigned Direct under experiment vllm-omni-strict-5050-20260829.

@vllm-omni-review-bot vllm-omni-review-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omni ReviewBot review

PR description

This PR updates the Qwen3-Omni /v1/realtime WebSocket E2E client helpers so the test speaks the current nested session.update / response.create contract, reads audio from delta, and waits for response.done plus response.output_audio.done. Synthetic turn-mode audio and chunk pacing move to 24 kHz PCM16, while Server VAD fixtures stay on explicit 16 kHz. The LiveKit client-VAD replay assertion is tightened from a generic assistant substring to qwen, matching the observed first-turn answer; no production serving code changes.

Change flow

flowchart TD
  A["[EXISTING] LiveKit replay / synthetic PCM / duplex fixtures"]:::existing --> B["[CHANGED] _pcm16_mono_from_wav_bytes + roundtrip helpers"]:::changed
  B --> C["[CHANGED] session.update nested type=realtime; commit + response.create"]:::changed
  C --> D["[EXISTING] /v1/realtime WebSocket server"]:::existing
  D --> E["[CHANGED] Parse output_audio/transcript events; assert audio_done + LiveKit answers"]:::changed
  classDef existing fill:#e5e7eb,stroke:#6b7280,color:#111827
  classDef changed fill:#fef3c7,stroke:#d97706,color:#451a03,stroke-width:2px
  classDef new fill:#dcfce7,stroke:#16a34a,color:#052e16,stroke-width:2px
  classDef removed fill:#fee2e2,stroke:#dc2626,color:#450a0a,stroke-width:2px
Loading

CI at 4321e6d9fa4e (2026-09-29T20:08:43.070186+00:00): required check(s) blocking: buildkite/vllm-omni (pending). Observed Buildkite: buildkite/vllm-omni-npu-ci (pending), buildkite/vllm-omni-intel-ci (pending), buildkite/vllm-omni (pending), and 1 more.

No actionable findings.


🤖 This review was generated by InferMatrix Copilot, an open-source repo-maintenance agent for PR review, CI debugging and issue triage. Try it on your own repo, and ⭐ star it if it helped!

@NickCao
NickCao enabled auto-merge (squash) September 29, 2026 20:18
@NickCao
NickCao disabled auto-merge September 29, 2026 20:23
@NickCao
NickCao merged commit 8ad6e80 into vllm-project:main Sep 29, 2026
7 of 9 checks passed
NickCao pushed a commit to neuralmagic/nm-vllm-omni-ent that referenced this pull request Oct 8, 2026
Signed-off-by: vraiti <vraiti@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
NickCao pushed a commit to neuralmagic/nm-vllm-omni-ent that referenced this pull request Oct 9, 2026
Signed-off-by: vraiti <vraiti@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
NickCao pushed a commit to neuralmagic/nm-vllm-omni-ent that referenced this pull request Oct 9, 2026
Signed-off-by: vraiti <vraiti@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

3 participants