Repository navigation
Conversation
LOGO127
force-pushed
the
test/duplex-resume-cancel-takeover-0927
branch
from
September 30, 2026 12:48
f290df4 to
eb46d06
Compare
Contributor
Author
|
Update: I fixed the CI formatting-only failure on the existing test-only change and pushed refreshed head |
Signed-off-by: luozijian <luozijian0924@gmail.com>
LOGO127
force-pushed
the
test/duplex-resume-cancel-takeover-0927
branch
from
October 2, 2026 08:57
eb46d06 to
4003916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test-only follow-up to #7429 after #7413 landed the production rollback behavior. The older conflicting implementation PR is closed; this PR changes no production code.
Parameterize the existing cancellation regression for attached takeover and detached reconnect, at both activation and replay (four combinations). Retain the attachment rollback and old-token recovery assertions. The inspected Oct-5 main snapshot
0b0d2d700still covers only the detached reconnect combinations in this regression, so the attached takeover coverage is not duplicated.Validation
Signed PR head:
4003916cb3bce0be56b985a40db3da745b5a262a.git diff --checkand applicable pre-commit hooks previously passed; the signed test source is unchanged.ced6857afa0ea7b2e3f0846a62e1394e90f15607.0b0d2d70090e1df820de95ef599e109981bf06d0and vLLM v0.31.0 sourcedb9527a46873454610df6dbedf79a36d6bf1a7f6also passed 25 tests, 0 skipped, including all four cancellation combinations. Post-run verification confirmed the tested attachment registry was imported from that main snapshot. This is a compatibility run, not a rebase or a merged candidate tree. The two runs cover the same cases and are not additive.Environment: WSL Python 3.12.3, PyTorch 2.11.0+cpu, Transformers 5.14.1. Installed vLLM distribution metadata remains 0.28.0; Python source imports were explicitly pinned as above. Only the CPU host's NVML discovery was adapted. Each run had one pytest/anyio import-rewrite warning. These results supersede the earlier initialization-bypassing supplemental run; they do not certify a rebuilt wheel, native kernels, the complete CI image, GPU, live serving, network transport or PersonaPlex resume support.
With compatible dependencies, from the PR checkout's
testsdirectory:python -m pytest entrypoints/openai/test_duplex_session_attachment.py \ -m 'core_model and cpu' --run-level core_model -qStatus
At the Oct-5 status check, DCO, Python 3.11/3.12 wheel builds and pre-commit are successful for this head. GitHub still shows docs Pending, but the Read the Docs API reports exact-commit build
34894885as cancelled, withsuccess=falseand no error text. The commit-filtered listing contains only that build; no replacement/live documentation job is evidenced, and no cancellation cause is inferred. No retrigger has been performed.Keeping this Draft pending final readiness review and the documentation check. Codex assisted with the test-only change, local verification and this description; this does not replace personal review or DCO attestation.