Repository navigation
[Bugfix] Fix MiniCPM-o 4.5 seeded turns and window E2E inputs - #8160
Merged
Merged
Conversation
Gaohan123
requested review from
NickCao,
Sy0307,
amy-why-3459,
gcanlin,
linyueqian,
tzhouam and
yenuo26
as code owners
September 25, 2026 16:24
|
This PR appears to belong to: docs/design/module/model_integration.md, docs/design/module/ar_runtime.md. Module owners: @tzhouam @fake0fan @gcanlin Routing: @tzhouam via module of the changed files, CODEOWNERS; @fake0fan via module of the changed files; @gcanlin via module of the changed files @Gaohan123, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
Signed-off-by: Gao Han <hgaoaf@connect.ust.hk>
Gaohan123
force-pushed
the
fix/issue-8154-duplex
branch
from
September 25, 2026 17:00
86ca8dc to
7a46fe7
Compare
Collaborator
Author
1 task done
nagisa-kunhah
pushed a commit
to nagisa-kunhah/vllm-omni
that referenced
this pull request
Oct 3, 2026
…roject#8160) Signed-off-by: Gao Han <hgaoaf@connect.ust.hk> Signed-off-by: nagisa-kun <1434936049@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses #8154.
Seeded MiniCPM-o 4.5 duplex requests fail with missing
response.doneand listen-only events. After #8152, the seed is marked pending, but its prompt opens an assistant turn while initialization still leavescurrent_turn_ended=True. Seeded plain-text requests can consequently remain listen-only. Initialize the existing native turn state with the seeded prefix and retain pending input throughtts_bos, consuming it on the first content token. The model'sturn_eosstill closes the response and later silence returns to normal listening.The short-window tests have a separate input problem: they discard context before retaining a complete 5.47-second fixture utterance, then stop the audio clock immediately after speech. The same input produced only listen decisions with windowing disabled. Retain enough context and send a five-second pause before commit. Basic and context windows still rebuild; completion, audio, error, close, subsequent-session, burst-input, camera, and two-minute-input assertions are unchanged.
Add a seed lifecycle regression covering absent/empty/English/Chinese text, speech-envelope handling, and silence after
turn_eos.AI assistance: Codex assisted investigation, implementation, test execution, and this PR description.
Test Plan
vLLM Version: 0.30.0; PyTorch 2.13.0+cu129; Transformers 5.14.1.
vLLM-Omni Commit: issue baseline
7a8d956; rebased onto main5d0963b3d. Fix commit:7a46fe7b4.Real
openbmb/MiniCPM-o-4_5weights and repository input fixtures on an NVIDIA L20X, with the repository uv environment andHF_HOME=/workspace/models. The issue's H100 hardware was not available locally. All inference/tests ran under exclusivegpu runreservations.Exact CI pytest command, from the repository root:
Focused regression:
Existing CI already collects these files; no Buildkite routing change is needed.
Test Result
7a46fe7b4: 20 passed, 1 deselected, exit 0, 1521.61 seconds (25m21s). All three short-window cases, all three continuous-input cases, and all three buffered-flush cases passed.precheck-prreview completed; all required local validation passed.The reported unbounded basic-window loop was not reproduced on unmodified rebased main: that continuous-input case passed in 213.77 seconds, with 132 real input units plus 64 bounded continuations. Repeated window replacement log lines alone do not demonstrate an infinite loop.
Merge-CI follow-up: main builds 16157 and 16158 show seven residual failures (seeded plain text, three short-window cases, three buffered cases), which these changes target. All three continuous-window cases passed there and in 16160. Build16157 also had a separate ordinary MiniCPM Code2Wav cuDNN failure; this PR does not change that backend or claim to fix it. Build16162 passed without selecting the MiniCPM jobs.