Repository navigation
[Feature][TTS] Seed MOSS-TTS residual sampling from the deploy seed #8078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jingchengtian
wants to merge
1
commit into
vllm-project:main
from
jingchengtian:perf/moss-tts-codec-chunk-ramp
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] tts_local_seed keeps the YAML seed over an explicit request seed
Evidence and suggested fix
apply_sampling_overridesnever readsrequest.seed. Whenever stage 0'sseedis not None itsetdefaults that value intoextra_args["tts_local_seed"].moss_tts_local_v1.yamlsets stage-0seed: 42, so the new key is installed for ordinary Local requests. MOSSTTS-3a says Local consumestts_local_seed(including seed 0) and that an explicit request seed must beat the stage default.build()still recordsrequest.seedontts_params["seed"], but this later write can disagree with it. The comment that the generic serving layer restores precedence is not implemented in this function, andserving_speech.pyis not in the snapshot, so a later overwrite of this key was not verified.test_prepare_speech_generation_moss_default_seed_sets_tts_local_seedmocksbuild(), leavesrequest.seedunset, and only asserts the default 42, so an explicit seed or seed 0 stays green. Ifextra_argsis already a shared dict,copy.copyaliases it andsetdefaultmutates the stage default. Writerequest.seedwhen it is not None, including 0, and use the stage seed only otherwise; copyextra_argsbefore updating it.