Repository navigation
[BugFix][Diffusion] Scope Wan RMSNorm patch to NPU - #8047
Conversation
|
This PR appears to belong to: docs/design/module/diffusion/offloader.md, docs/design/module/diffusion/diffusion_model_integration.md, docs/design/module/diffusion/index.md. Module owners: @wtomin @david6666666 @Isotr0py Routing: @wtomin via module of the changed files, module named in the PR description, CODEOWNERS; @david6666666 via module of the changed files, module named in the PR description; @Isotr0py via module of the changed files, module named in the PR description @Dong1017, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Signed-off-by: GUOGUO <xwdong1998@163.com>
bd506f9 to
b1bd11f
Compare
Pull request was closed
|
Self-review (precheck-pr quick, b1bd11f): I checked all three changed files against #8030: the NPU-only patch guard, restoration of WanRMS_norm aliases after patch tests, and the moved RMSNormVAE import. With diffusers 0.40.0 and vLLM 0.29.0, the combined tests reproduced six failures on main and passed 79/79 on this commit; Ruff and diff checks passed. The guard also changes CPU/CUDA runtime normalization selection, so full model-output parity remains unverified. Current NPU CI failures are in MiniCPM-o perf and Qwen3-TTS steps, while AMD and Intel CI are pending. The repository precheck also flagged title prefix casing and a legacy SPDX header for follow-up after CI. |
|
CI triage for
These failing jobs do not run the changed Wan VAE tests. The production guard in this PR still calls |
|
Root-cause timeline for #8030:
This PR limits automatic substitution to NPU, restores module bindings after the explicit patch tests, and corrects the import. With diffusers 0.40.0 and vLLM 0.29.0, the combined-order run reproduced six failures on the base revision and passed 79/79 on this revision. The CPU/CUDA class selection changes as a result; complete model-output parity remains unverified. |
Fixes #8030.
Importing the Wan 2.2 package replaced diffusers'
WanRMS_normglobally, including on CPU and CUDA. The Wan VAE fastpath only supports the original diffusers class, so its normalization optimization was skipped and six tests failed depending on import order. Apply the automatic replacement only on NPU, restore module aliases after tests that explicitly exercise the patch, and correct the movedRMSNormVAEtest import.Validation: reproduced the reported six failures on upstream
75570ee3awith diffusers 0.40.0; both affected test files now pass together (79 tests).ruff check,ruff format --check, andgit diff --checkpass. The reproduction host has vLLM 0.29.0; the reported CI used 0.30.0.