Repository navigation
[CI/Build] Retarget skipped HiDream and MammothModa2 E2E tests to current issues - #7755
Merged
Merged
Conversation
Signed-off-by: wangyu <410167048@qq.com>
…ct#7718 Signed-off-by: wangyu <410167048@qq.com>
Signed-off-by: wangyu <410167048@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
This PR matches CODEOWNERS paths: /tests/. Code owners: @NickCao Routing: @NickCao via CODEOWNERS @yenuo26, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
NickCao
approved these changes
Sep 18, 2026
NickCao
enabled auto-merge (squash)
September 18, 2026 13:21
linyueqian
added a commit
to Levius-Fubuki/vllm-omni
that referenced
this pull request
Sep 18, 2026
Resolve the conflict in tests/e2e/offline_inference/test_mammoth_moda2_expansion.py in favour of this branch. vllm-project#7755 retargeted the skip marker on test_mammothmoda2_t2i_e2e to vllm-project#7718; the shared-runtime migration here rewrites that test body and is the fix for the failure vllm-project#7718 tracks, so the skip stays removed. Signed-off-by: Yueqian Lin <linyueqian@outlook.com>
mlaneuville
pushed a commit
to mlaneuville/vllm-omni
that referenced
this pull request
Sep 22, 2026
…rent issues (vllm-project#7755) Signed-off-by: wangyu <410167048@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Matthieu Laneuville <matthieu.laneuville@surf.nl>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
…rent issues (vllm-project#7755) Signed-off-by: wangyu <410167048@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Retarget existing skip markers on two weekly/full-model E2E tests so they point at the issues that currently track the failures, instead of stale or closed bugs.
test_hidream_i1_image:#4662was closed (forced 1024×1024 rescale is upstream HiDream default). Custom resolution is now tracked by RFC [RFC]: Assign custom resolution for HiDream-I1 (honor requested width/height) #7753.test_mammothmoda2_t2i_e2e: skip reason updated from#3201to [Bug]: tests/e2e/offline_inference/test_mammoth_moda2_expansion.py::test_mammothmoda2_t2i_e2e[omni_runner0], AssertionError: No image tensor found in pipeline output #7718 (AssertionError: No image tensor found in pipeline output).This does not unskip the tests and does not fix the underlying product issues.
Relates to #7753
Relates to #7718
Test Plan
Skip-reason-only change; no new tests.
vLLM Version: N/A (test skip markers only)
vLLM-Omni Commit:
skip@95bddee21Confirm collection still skips the two cases:
Do not re-enable
--run-level full_modelfor these tests until #7753 / #7718 are resolved.Test Result
Not run locally: this PR only updates skip reasons. The HiDream 512 vs 1024 size mismatch and MammothModa2 missing image tensor are already documented on #7753 and #7718.
Pending: GitHub / Buildkite on this PR (pre-commit / lint).
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.