Skip to content

[Bugfix] Fix stable diffusion3 compatibility error #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsliuustc0106 merged 1 commit into from
Jan 13, 2026
Merged

[Bugfix] Fix stable diffusion3 compatibility error #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions vllm_omni/diffusion/models/sd3/sd3_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ def __init__(
else:
self.to_out = None

self.norm_added_q = RMSNorm(head_dim, eps=eps)
self.norm_added_k = RMSNorm(head_dim, eps=eps)
self.norm_added_q = RMSNorm(head_dim, eps=eps) if qk_norm else nn.Identity()
self.norm_added_k = RMSNorm(head_dim, eps=eps) if qk_norm else nn.Identity()

self.attn = Attention(
num_heads=num_heads,
Expand Down Expand Up @@ -341,8 +341,10 @@ def __init__(
self.pooled_projection_dim = model_config.pooled_projection_dim
self.joint_attention_dim = model_config.joint_attention_dim
self.patch_size = model_config.patch_size
self.dual_attention_layers = model_config.dual_attention_layers
self.qk_norm = model_config.qk_norm
self.dual_attention_layers = (
model_config.dual_attention_layers if hasattr(model_config, "dual_attention_layers") else ()
)
self.qk_norm = model_config.qk_norm if hasattr(model_config, "qk_norm") else ""
self.pos_embed_max_size = model_config.pos_embed_max_size

self.pos_embed = PatchEmbed(
Expand Down