Skip to content

[CI] Fix Structured Diffusion Config Wan Test - #7707

Merged
linyueqian merged 1 commit into
vllm-project:mainfrom
alex-jw-brooks:structured_config_fix
Sep 17, 2026
Merged

linyueqian merged 1 commit into
vllm-project:mainfrom
alex-jw-brooks:structured_config_fix

Conversation

@alex-jw-brooks

@alex-jw-brooks alex-jw-brooks commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Fixes #7704

get_diffusion_od_config isn't a valid method on the Omni class. There's one on the engine class here, which is probably what was originally intended, but this is a misnomer and gives a simple namespace with some of the model's metadata rather than the actual OmniDiffusionConfig 😞

The minimal fix is to pull the real OmniDiffusionConfig off of the stage clients. You can verify the test now passes with the command below:

pytest -s -v tests/e2e/offline_inference/test_wan22_t2v.py tests/e2e/online_serving/test_wan22_t2v.py -m 'advanced_model and cuda and diffusion' --run-level 'advanced_model' -k test_structured_diffusion_config_reaches_runtime

CC @linyueqian @yenuo26 PTAL. Thanks!

Passing build link: https://buildkite.com/vllm/vllm-omni/builds/15454/canvas

Signed-off-by: Alex Brooks <albrooks@redhat.com>
@vllm-omni-review-bot

Copy link
Copy Markdown

This PR appears to belong to: docs/design/module/diffusion/index.md.

Module owners: @david6666666 @Isotr0py @princepride

Routing: @david6666666 via module named in the PR description; @Isotr0py via module named in the PR description; @princepride via module named in the PR description

@alex-jw-brooks, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

@alex-jw-brooks alex-jw-brooks added the merge-test label to trigger buildkite merge test CI label Sep 17, 2026

@linyueqian linyueqian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at the current head. This fixes the failure I filed in #7704: the test I let through in #6849 called get_diffusion_od_config() on the Omni object, which has no such method, so Diffusion · Wan22 Test raised AttributeError on the first main build that ran it. The fix reads the real OmniDiffusionConfig off the single diffusion stage client and asserts its type, and the remaining assertions (stage_id, model, model_class_name == "WanPipeline", output_type == "pil") now run against that object, whose dataclass carries all four fields. That is also more honest than the engine helper the test probably meant, which returns a metadata namespace rather than the config. Test-only change, one file, no runtime code touched. Validation: static read of the diff and of OmniDiffusionConfig and the stage client; alex reports the offline and online test_struct* cases pass locally with the merge-pipeline command. Since the ready lane does not run this advanced_model test, the confirming run is this PR's own post-merge main build, which will include the Wan22 step because the test file changed; I will watch it.

@linyueqian
linyueqian merged commit 8c3d340 into vllm-project:main Sep 17, 2026
7 of 8 checks passed
@alex-jw-brooks alex-jw-brooks changed the title [CI] Fix Structured Structured Diffusion Config Wan Test [CI] Fix Structured Diffusion Config Wan Test Sep 17, 2026
mlaneuville pushed a commit to mlaneuville/vllm-omni that referenced this pull request Sep 22, 2026
…t#7707)

Signed-off-by: Alex Brooks <albrooks@redhat.com>
Signed-off-by: Matthieu Laneuville <matthieu.laneuville@surf.nl>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-test label to trigger buildkite merge test CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] main red on Diffusion · Wan22 Test after #6849 (merge-only test_structured_diffusion_config_reaches_runtime)

3 participants