Repository navigation
Conversation
Signed-off-by: andyluo7 <andy.luo@amd.com>
20389fc to
1561e58
Compare
|
This PR was classified as CI work. CI owner: @yenuo26 @congw729 @NickCao Routing: @yenuo26 via semantic router, CI owner, CODEOWNERS; @congw729 via CODEOWNERS; @NickCao via CODEOWNERS @andyluo7, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
|
Author self-review completed at exact head I checked that:
I reran the focused manifest/report tests: 5 passed. The report generator completed and |
|
Closing this tracking-only PR after revisiting ownership and scope. The parity ledger and report are useful for AMD program management, but this change does not select tests, schedule jobs, gate pull requests, or otherwise affect vLLM-Omni CI execution. We have retained the tooling in the AMD planning repository and will publish public-safe status, implementation PR links, exact-head Buildkite evidence, and approved exceptions through issue #5731. Upstream PRs will focus on executable ROCm CI coverage. If maintainers later want repository-native machine enforcement, we can propose a smaller CI-integrated guard derived from the executable pipeline definitions. |
Purpose
Track all 61 rows in #5731 with an executable CUDA/ROCm parity ledger instead of treating the issue bullets as a homogeneous test count.
This PR adds:
missing,partial, andunknownrows;The initial snapshot at upstream
78934753ff7e092b24ada0e34062cf3d121efd25is intentionally conservative: 37 missing, 3 partial, and 21 unknown. It makes no new coverage claims. The ledger now links the first implementation set: #7604, #7605, and #7606.Test Plan
python3 -m pytest --confcutdir=tests/buildkite -o 'addopts=' -q \ tests/buildkite/test_rocm_parity_manifest.py pre-commit run --files \ .buildkite/ci/rocm_cuda_parity.yaml \ .buildkite/ci/rocm_cuda_parity.schema.json \ .buildkite/scripts/generate_rocm_parity_report.py \ tests/buildkite/test_rocm_parity_manifest.py \ tools/pre_commit/check_buildkite.py python3 .buildkite/scripts/generate_rocm_parity_report.py --format markdownvLLM Version: N/A; metadata and CI tooling only.
vLLM-Omni Commit:
1561e586afab1e3e6dd022c38ad9fefa6bdfb6ffTest Result
5 passedgit diff --checkpassed.AI assistance: Used Codex to implement the manifest/report tooling, add contract tests, run the repository pre-check, and draft this PR description. I reviewed the changes and validation results.