Repository navigation
[Bugfix][MiniMax-H3] Preserve reference image geometry - #6992
Closed
heyuanliu-intel wants to merge 1 commit into
Closed
heyuanliu-intel wants to merge 1 commit into
heyuanliu-intel wants to merge 1 commit into
Conversation
heyuanliu-intel
requested review from
NickCao,
gcanlin,
princepride,
tzhouam and
yenuo26
as code owners
September 3, 2026 08:13
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR appears to be related to model: MinimaxH3. Model owners: @david6666666 @heyuanliu-intel, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
## Purpose **Problem:** `serving_video` rescales every reference image to the request canvas. MiniMax-H3 expects reference images at their native geometry, so ref2va silently replaces the reference aspect ratio with the canvas one. **Fix:** register an H3-specific `reference_image_size_resolver` through the existing `model_extras/registry.py` extension point that keeps the source geometry. Pipelines without a resolver keep the serving-side resize. ## Test Plan **Reproduce:** send a ref2va request with a 48x32 reference image and a 96x64 canvas; the engine receives a 96x64 image. ```bash pytest -q tests/model_extras/test_model_extras.py -k minimax_h3_preserves_reference_image_size pytest -q tests/entrypoints/openai_api/test_video_server.py -k minimax_h3_preserves_reference_geometry ``` **vLLM Version:** as pinned by `requirements/`. **vLLM-Omni Commit:** rebased onto current `main`. ## Test Result CPU tests pass: the engine receives the 48x32 image while sampling params still carry (96, 64). Dropping the registry entry makes the serving test observe 96x64 again. Signed-off-by: heyuanliu-intel <heyuan.liu@intel.com>
heyuanliu-intel
force-pushed
the
pr/h3-reference-image-geometry
branch
from
September 3, 2026 08:38
cab3b57 to
870fefb
Compare
hsliuustc0106
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Problem:
serving_videorescales every reference image to the request canvas. MiniMax-H3 expects reference images at their native geometry, so ref2va silently replaces the reference aspect ratio with the canvas one.Fix: register an H3-specific
reference_image_size_resolverthrough the existingmodel_extras/registry.pyextension point that keeps the source geometry. Pipelines without a resolver keep the serving-side resize.Test Plan
Reproduce: send a ref2va request with a 48x32 reference image and a 96x64 canvas; the engine receives a 96x64 image.
vLLM Version: as pinned by
requirements/. vLLM-Omni Commit: rebased onto currentmain.Test Result
CPU tests pass: the engine receives the 48x32 image while sampling params still carry (96, 64). Dropping the registry entry makes the serving test observe 96x64 again.