Repository navigation
[CI/Build] Add experimental AMD MI300 nightly lane - #6978
Conversation
|
Self-review completed on exact head
Validation:
@yenuo26 @congw729, I cannot add repository labels with this account ( Exact-head MI300 results are still pending and are not claimed by this self-review. |
e415518 to
57062ed
Compare
|
Restacked the draft onto #6966 review follow-up The rebase preserves the fail-closed PR-label lookup and removal of the two unused legacy label branches while extending suite selection to L4. Validation is green locally: AMD selector/nightly/skip-CI tests The prior runtime request is now superseded by this head. @yenuo26 @congw729, when the static checks finish, please apply |
57062ed to
3be8cf4
Compare
3be8cf4 to
f0edcdf
Compare
f0edcdf to
f9d5cd4
Compare
|
Self-review update for rebased exact head
The external Buildkite condition still needs a separate update to admit |
|
This PR was classified as CI work. CI owner: @yenuo26 @hsliuustc0106 Routing: @yenuo26 via semantic router, CI owner, CODEOWNERS; @hsliuustc0106 via CODEOWNERS @andyluo7, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
|
AMD L4 burn-in follow-up for exact head Build #11646 exercised all four intended Baseline observation (run 1):
@yenuo26 @congw729, could one of you please run two additional isolated retries of these two jobs on the same exact head?
If per-job retry is unavailable, two AMD-nightly-only runs are sufficient. I do not have Buildkite retry credentials in this environment, and a GitHub Please keep the Seed-TTS artifact for each run. We should collect the additional ROCm observations before deciding whether a platform baseline is warranted; this request does not propose changing the |
f9d5cd4 to
17af998
Compare
|
Rebase and merge-readiness update:
The earlier retry request on For merge readiness, the immediate goal is to verify that the rebased head selects and runs the four intended non-blocking L4 jobs. Two further isolated retries of Function Expansion and Accuracy, with each Seed-TTS artifact retained, remain useful burn-in evidence and would give three observations on the new SHA; they are not a proposal to change the current @hsliuustc0106, please review the CI configuration when the fresh exact-head checks have registered. |
17af998 to
f015caf
Compare
|
Review fixes are now on exact head
Local validation: 128 focused/general Buildkite tests passed, all changed-file pre-commit hooks passed, and Bash syntax, ShellCheck, Buildkite schema, DCO, and @yenuo26 @congw729, the remaining prerequisite for exact-head AMD validation is the external The PR already carries |
Signed-off-by: andyluo7 <andy.luo@amd.com>
f015caf to
f7601d6
Compare
Signed-off-by: andyluo7 <andy.luo@amd.com>
Signed-off-by: andyluo7 <andy.luo@amd.com>
|
Exact-head AMD validation is complete for
The PR description now contains the full terminal evidence and artifact links. The external order-independent @yenuo26 @hsliuustc0106, could you please take a final look and approve if there are no further issues? |
|
Second exact-head AMD nightly observation is complete for
Together with #11712, this gives two successful observations on the current exact head. All current GitHub checks are green, the new AMD jobs remain non-blocking, and the Seed-TTS threshold remains unchanged. @congw729 @NickCao @Gaohan123 @david6666666, could one of you please take a final look and approve if there are no remaining concerns? |
Signed-off-by: andyluo7 <andy.luo@amd.com>
Purpose
Add a small, experimental AMD/ROCm MI300
full_modelnightly vertical slice while AMD ready/merge coverage continues to burn in.This PR:
.buildkite/amd/test-amd-nightly.ymlwith four MI300/Qwen3-Omni jobs:nightly-testand scheduledmainbuilds withNIGHTLY=1to the AMD nightly suiteready,merge-test, andnightly-testsuites to be combined behind one AMD image buildThis is intentionally not the CUDA L4 configuration copied wholesale. Performance is deferred until an MI300 baseline and measurement protocol exist; this PR does not import H100 thresholds. AMD coverage publication and broader model/hardware expansion remain follow-ups.
Rebase and trigger status
This PR is based directly on
mainatd3493384cfc6c4b9ba1fc4e534e91fe588ecb4f1; the exact head isaa5b535c6927ea2946c8c5c72faaa17c493b7dd5. This ancestry includes the corrected ROCm vLLM 0.29 image from #7395.AMD label handling has two layers:
amd-testadmits the external AMD Buildkite pipeline.nightly-testmakes the repository bootstrap select onlyNIGHTLY_TESTS:test-amd-nightly.yml.For AMD-only nightly validation, the external Buildkite condition must accept a label event when the complete PR label set contains both
amd-testandnightly-test. The event should be accepted when either member of the pair is applied last, making the trigger order-independent. A manual exact-head build withDEBUG_TEST_YAML=nightlyvalidated the repository lane independently of that external trigger change.Related to #5731.
Test Plan
vLLM Version: N/A (CI configuration only)
vLLM-Omni Commit:
aa5b535c6927ea2946c8c5c72faaa17c493b7dd5pre-commitsuiteshellcheck .buildkite/amd/scripts/bootstrap-amd-omni.shbash -n .buildkite/amd/scripts/bootstrap-amd-omni.sh.buildkite/amd/test-amd-nightly.ymlgit diff --checkTest Result
aa5b535c, 77 focused tests passed. Changed-file pre-commit, YAML validation, the artifact-copy simulation, andgit diff --checkpassed.aa5b535cwithDEBUG_TEST_YAML=nightly:NIGHTLY_TESTS:test-amd-nightly.ymland rendered exactly four non-blockingamd_mi300_2leaves.0.29.0, TorchCodec0.10.0a0, a successful finalVideoDecoderimport, and digestsha256:09e50771c1cee2cef8c6ae0cd8e41db9c775ba8c128499b79a3c19b6c63ad80d.26 passed; the earliertest_speaker_002[async_chunk]mismatch did not reproduce.2 passed. Daily-Omni evaluated all 1,197 samples with zero request/parse failures and accuracy0.7184628237259816. Seed-TTS evaluated all 1,088 samples with zero request, PCM, or ASR/WER failures; mean WER was0.33326678996457526, below the unchanged0.35maximum.7 passed.3 passed, withVLLM_ROCM_USE_AITER=1andmodule_aiter_core.soloaded.aa5b535cdefers those variables to job runtime and adds regression coverage; #11712 confirms the corrected pipeline uploads and runs end to end.0.3379, while #11646 measured0.376480. The0.35threshold is unchanged, and the four AMD nightly leaves remain non-blocking during burn-in.