Repository navigation
[CI][ROCm] Fix deterministic AMD L3 blockers - #6884
Conversation
Signed-off-by: andyluo7 <andy.luo@amd.com>
278b7e7 to
8ad4cd7
Compare
|
Self-review completed:
The remaining acceptance test must be the real AMD L3 suite on this exact head. @yenuo26 @hsliuustc0106, could one of you please add the merge-test and amd-test labels? I attempted it, but the fork author account does not have label permission. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR was classified as CI work. CI owner: @yenuo26 @andyluo7, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
|
Author self-review (after CI-owner assignment): I verified the full diff against current main, confirmed the AMD Jinja renderer joins the separate export and pytest lines into one shell, reproduced the final pytest argv, and checked the ROCm-only cache override through the deploy projection with an explicit CUDA non-regression assertion. Static checks are green. The change still requires the requested real AMD L3 run before merge. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
|
Thanks. I checked build #11263: it ran on PR #6829 at This PR head already contains #6830’s ROCm-specific comparison, and all four Simple Diffusion shards passed on MI300 in AMD build #11230. That build then failed on the Qwen3-Omni and Qwen3-TTS Base L3 jobs addressed by this PR. Could you trigger a fresh L2 run and the AMD L3 merge-test on head |
congw729
left a comment
There was a problem hiding this comment.
The code changes look reasonable to me, and I did not find a blocking issue in the diff. The focused regressions cover both the Qwen3-TTS argument preservation and the ROCm-only KV-cache override while keeping CUDA unchanged.
Before approval, I would still like to see the AMD L3 merge test run on the current head 8ad4cd7, especially the Qwen3-TTS Base and Qwen3-Omni colocate-async jobs, since those are the behaviors this PR is intended to fix.
|
Thanks @congw729. The branch is now at I checked the bootstrap log: that run rendered @hsliuustc0106 @yenuo26, could you share the Buildkite build number if the AMD L3 run is already registered, or trigger |
Signed-off-by: andyluo7 <andy.luo@amd.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Signed-off-by: andyluo7 <andy.luo@amd.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Signed-off-by: ZhengWG <zwg0606@gmail.com>
Signed-off-by: andyluo7 <andy.luo@amd.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Summary
Why
Recent AMD L3 main runs repeatedly fail these two blocking jobs. The TTS job falls back to core-model dummy weights because its nested single quotes terminate the outer bash command before --run-level reaches pytest. The colocate test loads about 64.5 GiB of weights, then percentage sizing attempts about 125 GiB of KV cache for an 8K-token control-plane test and fails during allocation.
Validation
Full project pytest is unavailable on the local macOS checkout because its Torch/vLLM environment is not installed. This draft therefore requires a real AMD L3 merge-test run before either blocker is considered resolved.
CI request
Please trigger the AMD merge-test/L3 suite on this exact head. The acceptance gate is that both Qwen3-TTS Base E2E Test and Qwen3-Omni colocate async complete successfully with real weights on MI300.