Repository navigation
[Bugfix] Reconcile env-var inventory with post-#6217 main drift - #6631
Merged
Merged
Conversation
Merge-window drift broke the new environment-variable ratchet on main (build 14119): #6255 added the VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT read in the diffusion engine and #6362 removed the last package reference to ROSVOT_SOURCE_DIR, both after #6217's CI run. - Classify VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT as PUBLIC_OMNI and document it in the environment-variables reference page. - Drop the stale ROSVOT_SOURCE_DIR model-specific row now that the SoulX-Singer implementation is gone. - Update the reviewed snapshot counts and disposition tables to match. Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
hsliuustc0106
requested review from
Gaohan123,
NickCao,
alex-jw-brooks,
david6666666,
lishunyang12 and
yenuo26
as code owners
August 25, 2026 22:06
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR was classified as CI work. CI owner: @yenuo26 @hsliuustc0106, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
1 task done
1 task done
AndyZhou952
pushed a commit
to AndyZhou952/vllm-omni
that referenced
this pull request
Aug 26, 2026
… drift (vllm-project#6631) Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com> Signed-off-by: AndyZhou952 <jzhoubc@connect.ust.hk>
JoseCarlosGarcia95
pushed a commit
to valendra-tech/vllm-omni
that referenced
this pull request
Sep 5, 2026
… drift (vllm-project#6631) Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
… drift (vllm-project#6631) Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main is red after the merge of #6217 (build 14119,
Simple · Other Testlane): both new environment-variable ratchet tests fail.This is merge-window drift, not a defect in #6217 itself — its CI ran before two sibling commits landed:
VLLM_OMNI_ASYNC_OUTPUT_TIMEOUTread invllm_omni/diffusion/diffusion_engine.py(async-output wait bound) — an unclassified static access.ROSVOT_SOURCE_DIR, leaving a dead inventory row.Fix
VLLM_OMNI_ASYNC_OUTPUT_TIMEOUTasPUBLIC_OMNIand document it in theServing and runtimetable of the reference page (float seconds, default600, non-float/<=0warns once and falls back — matching the engine's resolution-on-request-path contract).ROSVOT_SOURCE_DIRmodel-specific row (dispositiondeprecate_removeis now moot: the implementation is gone).Validation
No runnable env on the review host, so the AST ratchets were validated standalone by loading the inventory module directly and exec'ing the test module:
test_inventory_matches_reviewed_snapshot_counts, prefix rule, classified-accesses, still-referenced, scanner coverage, reference page, redaction). The twocollect_envtests were not runnable locally (need vllm import); they are untouched by this change — collect_env derives its safe-report set from the inventory, and a numeric timeout knob is not sensitive.