Skip to content

[Bugfix] Reconcile env-var inventory with post-#6217 main drift - #6631

Merged
hsliuustc0106 merged 1 commit into
mainfrom
codex-fix-env-var-ratchet-6217
Aug 25, 2026
Merged

hsliuustc0106 merged 1 commit into
mainfrom
codex-fix-env-var-ratchet-6217

Conversation

@hsliuustc0106

Copy link
Copy Markdown
Collaborator

Problem

Main is red after the merge of #6217 (build 14119, Simple · Other Test lane): both new environment-variable ratchet tests fail.

FAILED tests/config/test_environment_variables.py::test_statically_resolvable_environment_accesses_are_classified
  Extra items in the left set: 'VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT'
FAILED tests/config/test_environment_variables.py::test_model_and_benchmark_inventory_entries_are_still_referenced
  Extra items in the left set: 'ROSVOT_SOURCE_DIR'

This is merge-window drift, not a defect in #6217 itself — its CI ran before two sibling commits landed:

Fix

  • Classify VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT as PUBLIC_OMNI and document it in the Serving and runtime table of the reference page (float seconds, default 600, non-float/<=0 warns once and falls back — matching the engine's resolution-on-request-path contract).
  • Drop the stale ROSVOT_SOURCE_DIR model-specific row (disposition deprecate_remove is now moot: the implementation is gone).
  • Update the pinned snapshot counts (PUBLIC_OMNI 22→23, MODEL_SPECIFIC 57→56, DEPRECATE_REMOVE 7→6) in the test and the audit-count prose/table in the reference page.

Validation

No runnable env on the review host, so the AST ratchets were validated standalone by loading the inventory module directly and exec'ing the test module:

  • before: exactly the two CI failures reproduce;
  • after: all inventory/scanner/docs ratchets pass (test_inventory_matches_reviewed_snapshot_counts, prefix rule, classified-accesses, still-referenced, scanner coverage, reference page, redaction). The two collect_env tests were not runnable locally (need vllm import); they are untouched by this change — collect_env derives its safe-report set from the inventory, and a numeric timeout knob is not sensitive.

Merge-window drift broke the new environment-variable ratchet on main
(build 14119): #6255 added the VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT read in
the diffusion engine and #6362 removed the last package reference to
ROSVOT_SOURCE_DIR, both after #6217's CI run.

- Classify VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT as PUBLIC_OMNI and document
  it in the environment-variables reference page.
- Drop the stale ROSVOT_SOURCE_DIR model-specific row now that the
  SoulX-Singer implementation is gone.
- Update the reviewed snapshot counts and disposition tables to match.

Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vllm-omni-review-bot

Copy link
Copy Markdown

This PR was classified as CI work.

CI owner: @yenuo26

@hsliuustc0106, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

@hsliuustc0106
hsliuustc0106 merged commit a708ae5 into main Aug 25, 2026
5 of 6 checks passed
AndyZhou952 pushed a commit to AndyZhou952/vllm-omni that referenced this pull request Aug 26, 2026
… drift (vllm-project#6631)

Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
Signed-off-by: AndyZhou952 <jzhoubc@connect.ust.hk>
JoseCarlosGarcia95 pushed a commit to valendra-tech/vllm-omni that referenced this pull request Sep 5, 2026
… drift (vllm-project#6631)

Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
… drift (vllm-project#6631)

Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Merge CI, test_statically_resolvable_environment_accesses_are_classified - AssertionError VLLM_OMNI_ASYNC_OUTPUT_TIMEOUT

2 participants