Repository navigation
[Bugfix] Build CUDA release/nightly images on vLLM 0.27 base - #6612
panpan0000 wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR was classified as CI work. CI owner: @yenuo26 @panpan0000, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
|
Self-review: one-line change, What I checked:
Not verified: I did not run a full image build or boot test locally (no GPU host); relying on CI for that. The already-published @vllm-omni-review-bot automated review welcome. |
Since vllm-project#5976 rebased vLLM-Omni onto vLLM 0.27.0, the release pipeline (.buildkite/release/release-pipeline.yml) keeps building docker/Dockerfile.cuda with its default BASE_IMAGE pinned at vllm/vllm-openai:v0.26.0. The published v0.27.0rc1 and nightly CUDA images therefore install current vLLM-Omni (which requires vLLM 0.27 APIs) over an incompatible vLLM 0.26.0 runtime, a combination CI never validates (Dockerfile.ci uses VLLM_BASE_TAG=v0.27.0). Confirmed on the published v0.27.0rc1 image: the inherited label ai.vllm.image.tag=vllm/vllm-openai:v0.26.0 shows the actual build base (Dockerfile.cuda has no LABEL overrides and does not reinstall vLLM). Align the release image base with the CI image base. Prior attempt in vllm-project#6378 was closed unmerged by its author without maintainer objection. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
2cf1b75 to
9412a06
Compare
|
@lengrongfu PTAL |
hsliuustc0106
left a comment
There was a problem hiding this comment.
Critical version alignment fix. The CUDA release images were built on vLLM 0.26.0 base while codebase uses vLLM 0.27.0 APIs - this prevents runtime compatibility issues. Simple but essential change.
|
Thank you @hsliuustc0106 |
|
hmm.. my pr was late.. |
Yeah, no longer applicable as we are now on 0.28: vllm-omni/docker/Dockerfile.cuda Line 1 in ea14b04 |
When I was digging which image works best for Minimax-H3, I found this issue on Dockerfile...
This PR are created with AI assistant...
Summary
docker/Dockerfile.cuda(the Dockerfile built by.buildkite/release/release-pipeline.ymlfor release and nightly CUDA images) still defaults toARG BASE_IMAGE=vllm/vllm-openai:v0.26.0, while the codebase was rebased onto vLLM 0.27.0 in [Rebase] Rebase to vllm 0.27.0 #5976.vllm/vllm-omni:v0.27.0rc1,latest, and dailynightlyCUDA images install current vLLM-Omni — which uses vLLM 0.27-only APIs — over a vLLM 0.26.0 runtime, a combination CI never validates (docker/Dockerfile.ciusesVLLM_BASE_TAG=v0.27.0).Dockerfile.ci("Keep VLLM_BASE_TAG aligned with the target vLLM release on every rebase"). The ROCm release Dockerfile was already fixed the same way in [ROCm] [CI] Migrate CI to mi300x for v0.27.x #5886.Evidence
vllm/vllm-omni:v0.27.0rc1via the Docker Hub registry API showsai.vllm.image.tag = vllm/vllm-openai:v0.26.0. Labels are inherited from the actual build base;Dockerfile.cudahas noLABELoverrides and does not reinstall vLLM.vllm/vllm-openai:v0.27.0was published 2026-08-10, ~20h before the v0.27.0rc1 image build (2026-08-11), so a correct base was available.-f docker/Dockerfile.cudaand passes no--build-arg BASE_IMAGEoverride, so the stale default is what ships.Test plan
v0.27.0rc1tag remains affected (immutable)